FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PR for taskphp/task#6 by laurisb · Pull Request #1 · taskphp/cli · GitHub

/ cli Public

PR for taskphp/task#6 - #1

Merged
mbfisher merged 5 commits into
taskphp:masterfrom
laurisb:patch-1
May 30, 2014
ConversationCommits (5)ChecksFiles changed
Merged

PR for taskphp/task#6#1
mbfisher merged 5 commits into
taskphp:masterfrom
laurisb:patch-1

Conversation

laurisb commented May 30, 2014

Copy link
Copy Markdown
Contributor

Add multiple options for Taskfile name

mbfisher commented May 30, 2014

Copy link
Copy Markdown
Contributor

Great, thanks! Looking into it now.

Travis build is failing, I suspect because the tests haven't been updated.

M

mbfisher reviewed May 30, 2014
View reviewed changes
Comment thread src/ProjectFinder.php Outdated

mbfisher May 30, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a syntax error. Can just be:

if (!($project instanceof Project)) {

laurisb commented May 30, 2014

Copy link
Copy Markdown
Contributor Author

Fixed.

coveralls commented May 30, 2014

Copy link
Copy Markdown

Coverage decreased (-13.64%) when pulling 0ffd690 on laurisb:patch-1 into d701084 on taskphp:master.

mbfisher commented May 30, 2014

Copy link
Copy Markdown
Contributor

Yup, tests are failing. Can you update them and add coverage for the new functionality please?

M

laurisb commented May 30, 2014

Copy link
Copy Markdown
Contributor Author

Done.

mbfisher commented May 30, 2014

Copy link
Copy Markdown
Contributor

Brilliant, thanks!

I've PRd your PR with a couple of tweaks, including removing those extra project checks that you've highlighted.

M

Merge pull request #1 from mbfisher/patch-1
580f58f 
Remove superfluous project checks

coveralls commented May 30, 2014

Copy link
Copy Markdown

Coverage remained the same when pulling 580f58f on laurisb:patch-1 into d701084 on taskphp:master.

mbfisher added a commit that referenced this pull request May 30, 2014
Merge pull request #1 from laurisb/patch-1
07e814e 
Merge pull request #1 from laurisb/patch-1
mbfisher merged commit 07e814e into taskphp:master May 30, 2014

mbfisher commented May 30, 2014

Copy link
Copy Markdown
Contributor

Thanks again!

M

mbfisher added a commit that referenced this pull request May 30, 2014
Merge pull request #1 from laurisb/patch-1
e3133d6 
Merge pull request #1 from laurisb/patch-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL