feat(health): Add configurable upstream error rules - #830
tbphp wants to merge 2 commits into
Conversation
Sorry, something went wrong.
Walkthrough新增全局和分组自定义错误规则。后端负责校验、继承和应用规则，并将分组规则传入网关健康决策。经典版和现代版前端新增规则配置、编辑、验证及日志标识展示。 Priority: ➖ Normal Merge Risk: 🟡 Moderate · up to bcdf6 Entering a cooldown in the modern rule editor can prevent the rule from updating. Fix that editing path before merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
Explanation Docstring coverage is 2.13% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 47 functions across 35 files. (9 skipped: 9 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
web/src/frontends/modern/features/config/ErrorRulesEditor.vue-142-190 (1)142-190: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
将现代编辑器的 cooldown 更新值转换为字符串。
现代 AppTextField 的 number 输入会将可解析值写为数字。随后 errorRuleValue 对 row.cooldown 调用 trim()，会抛出类型错误并阻断现代编辑器更新规则。经典编辑器发送字符串，不受此问题影响。
建议修复- v-model="row.cooldown" + :model-value="row.cooldown" + @update:model-value="row.cooldown = String($event)"
ℹ️ Review info ⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: QUIET
- Plan: Advanced
- Run ID: 47480bf5-4dd9-46ad-a09f-0b9f3ec5e50c
Reviewing files that changed from the base of the PR and between a5c691b and bcdf661.
📒 Files selected for processing (44)- internal/control/error_rules_test.go
- internal/control/group_detail.go
- internal/control/group_settings.go
- internal/control/settings.go
- internal/gateway/custom_error_rules_test.go
- internal/gateway/handler.go
- internal/gateway/jev_decision.go
- internal/gateway/live.go
- internal/gateway/mistral_realtime.go
- internal/gateway/websocket_turn.go
- internal/health/decision.go
- internal/health/error_rules.go
- internal/health/error_rules_test.go
- internal/health/execution_judge.go
- internal/state/error_rules_test.go
- internal/state/runtime_settings.go
- internal/state/snapshot.go
- web/src/frontends/classic/api/control/types.ts
- web/src/frontends/classic/app/resources/groups.ts
- web/src/frontends/classic/app/resources/settings.ts
- web/src/frontends/classic/components/config/ErrorRulesEditor.vue
- web/src/frontends/classic/features/groups/group-route.ts
- web/src/frontends/classic/features/groups/settings/GroupSettingsTab.vue
- web/src/frontends/classic/features/groups/settings/group-settings-patch.ts
- web/src/frontends/classic/features/monitor/LogDetailDrawer.vue
- web/src/frontends/classic/features/settings/ReliabilitySettingsSection.vue
- web/src/frontends/classic/features/settings/SettingsView.vue
- web/src/frontends/classic/features/settings/settings-patch.ts
- web/src/frontends/classic/i18n/locales/en-US/core.ts
- web/src/frontends/classic/i18n/locales/ja-JP/core.ts
- web/src/frontends/classic/i18n/locales/zh-CN/core.ts
- web/src/frontends/modern/api/group-detail.ts
- web/src/frontends/modern/api/settings.ts
- web/src/frontends/modern/features/config/ErrorRulesEditor.vue
- web/src/frontends/modern/features/groups/GroupAdvancedPanel.vue
- web/src/frontends/modern/features/logs/LogDetailPanel.vue
- web/src/frontends/modern/features/settings/SettingsView.vue
- web/src/frontends/modern/features/settings/settings-draft.ts
- web/src/frontends/modern/features/settings/use-settings-editor.ts
- web/src/frontends/modern/i18n/locales/en-US.ts
- web/src/frontends/modern/i18n/locales/ja-JP.ts
- web/src/frontends/modern/i18n/locales/zh-CN.ts
- web/src/shared/error-rule-messages.ts
- web/src/shared/error-rules.ts
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Sorry, something went wrong.
|
Addressed the cooldown input issue in ef85c66: the modern rule editor converts numeric input updates to strings before parsing. The same commit omits empty optional condition arrays when reading rules, so editing and then restoring a rule no longer leaves settings marked as changed. make check passed. The docstring coverage warning in the review summary is not a quality gate defined by this repository, so no bulk docstring changes are included. |
Sorry, something went wrong.
关联 Issue / Related Issue
Refs #753
变更内容 / Change Content
Allow operators to configure how existing upstream errors are handled. Rules match HTTP status codes and case-insensitive keywords in error codes, types, or messages, then select a retry directive and one state action: no change, model cooldown, credential cooldown, failure counting toward blacklisting, or skipping the group for the current request.
Rules only use existing error evidence, including errors already recognized under HTTP 200. New non-streaming 2xx error detection and scanning normal answer text remain outside this change. Credential probes and recovery behavior are unchanged. No schema migration or new dependency is required.
Validation: make check covers Go vet, frontend lint/style/format checks, TypeScript checks, builds, and go test -count=1 . ./internal/.... New backend regression tests cover matching, first-match priority, inheritance and empty overrides, replay constraints, failure counting, cooldown, and request-log decisions.
自查清单 / Checklist
Public documentation and release notes are unchanged; no documentation update is included in this PR.