Fix serialization / deserialization of char array. - #21
Merged
tcalmant merged 2 commits intoMay 31, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
|
Coverage decreased (-0.7%) to 84.317% when pulling 38c7b92 on moriyoshi:moriyoshi/fix-type-char-unpack into 8472ed9 on tcalmant:master. |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Thanks for your contribution! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you for looking into this! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the following issues:
For example using unpack spec '>hh" on "\xff\xff" results in (-1, -1) and causes ValueError in bytes().
Just fixing the above doesn't solve all the problems. Applying.decode('utf16-be') on a resulting buffer of such two bytes that represent surrogate pairs ends up in UnicodeDecodeError.
I don't really think that it is a good idea to manipulate strings for debugging regardless of its being enabled or not.
In py2 bytes is merely an alias of str, which doesn't construct a sequence of bytes from a iterator.
It's not been implemented at all.