feat(django): upgrade django framework and deps - #141
Merged
Cryptophobia merged 1 commit intoMar 21, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Cryptophobia
requested review from
dmcnaught,
duanhongyi,
felixbuenemann,
jfuechsl,
kingdonb and
notmaxx
March 20, 2021 18:00
Cryptophobia
force-pushed
the
feature/upgrade-django-framework-and-deps
branch
from
9e11502 to
bed17a7
Compare
March 20, 2021 18:15
This was referenced Mar 20, 2021
Cryptophobia
force-pushed
the
feature/upgrade-django-framework-and-deps
branch
from
bed17a7 to
c80ba13
Compare
March 20, 2021 18:26
yebyen
approved these changes
Mar 20, 2021
yebyen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
👍
Sorry, something went wrong.
Cryptophobia
force-pushed
the
feature/upgrade-django-framework-and-deps
branch
2 times, most recently
from
cd67e6c to
5b3fb67
Compare
March 21, 2021 05:20
- upgrading django to 2.2.19 and djangorestframework to 3.12.2 - resolving all failing tests due to above upgrade - upgrade models to default `on_delete=models.CASCADE` if app or user are deleted - upgrade all other dependencies to latest versions - update Makefile to use hephy/shell-dev for tests - update Dockerfile to use `hephy/base:latest` for building - update Dockefile to use python3 -m pip commands - upgrade pip, setuptools, wheel using python3 command - resolves teamhephy#140 - resolves teamhephy#80 Signed-off-by: Cryptophobia <aouzounov@gmail.com>
Cryptophobia
force-pushed
the
feature/upgrade-django-framework-and-deps
branch
from
5b3fb67 to
fa49020
Compare
March 21, 2021 05:32
kingdonb
reviewed
Mar 22, 2021
kingdonb
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cryptophobia aouzounov@gmail.com