Rewrite Meetup class - #11
Open
sukima wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
sukima
force-pushed
the
feature/Meetup-object-redux
branch
from
898a18d to
04de873
Compare
November 6, 2015 02:17
sukima
force-pushed
the
feature/Meetup-object-redux
branch
from
770717b to
b46066d
Compare
November 6, 2015 02:35
Copy link
Copy Markdown
Author
|
This is ready for review/merge. Next step is to pull the constants EVENTS_URL and MEMBERS_URL out of the code and into some config. But that can be for another pull request. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
As an aside… might want to consider using a package manager for vendor scripts like bower or npm. |
Sorry, something went wrong.
This is more JavaScript class idiomatic. It also allows for future abstractions like removing the hard coded URLs. The original file used tabs so I kept that even though the .vimrc seems to contradict this. This also uses UMD for encapsulation which makes it more universal to be pulled into other websites.
window.onload will overwrite and isn't really the best place since it doesn't take into account when the DOM is ready. We have jQuery so use it to initialize correctly.
sukima
force-pushed
the
feature/Meetup-object-redux
branch
from
9e02617 to
aa238b4
Compare
November 8, 2015 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more JavaScript class idiomatic. It also allows for future abstractions like removing the hard coded URLs.
The original file used tabs so I kept that even though the .vimrc seems to contradict this.
This also uses UMD for encapsulation which makes it more universal to be pulled into other websites.