Add dynamic "next meetup" to home page by iLtc · Pull Request #33 · techcorridorio/techcorridorio.github.io · GitHub

This pull request tries to resolve #27 .

Note: The javascript code, include the api signature, modify from _includes/meetup_cards.html .

We can also:

Add event description to the alt attribute
Change date format
Change link style
Move the javascript code to a separate file

Merge pull request techcorridorio#32 from iLtc/master

So that I can get the code back~ This reverts commit cfc403a.

This should probably use $(document).ready(function ...) (or just $(function ...))

I cannot use $(document).ready(function ...) here since jQuery will be imported after this code. Would you mind if I move <script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.2/jquery.min.js"></script> to <head>?

It might be nice to have this in a separate .js file.

I moved most of the js code to js/meetup-events.js but left the trigger code here.

Is this necessary?

I removed it.

Can we refactor that code so it's reusable without copying and pasting?

I moved all the js code to js/meetup-events.js. If you want, I can refactor _includes/meetup_cards.html and _includes/developers_cards.html so they share the same code file.

This is exactly what I was hoping for, but we should probably clean up the code a little before merging.

Line is too long.
Mixed double and single quotes.

Misleading line break before '+'; readers may interpret this as an expression boundary.

Line is too long.
Misleading line break before '+'; readers may interpret this as an expression boundary.

Misleading line break before '+'; readers may interpret this as an expression boundary.

Mixed double and single quotes.

Line is too long.
Mixed double and single quotes.

Line is too long.
Mixed double and single quotes.
Identifier 'address_1' is not in camel case.

'createEventParagraph' is defined but never used.

'EventPresenter' is defined but never used.

'Mustache' is not defined.

Line is too long.

Sorry for the delay. I hope it was not too late.

It is a little bit difficult to solve all the problems raised by HoundCI. For example, Mustache is defined in another file. I am not sure how to fix it here.

Let me know what you think~

iLtc added 4 commits February 11, 2017 15:30

Merge pull request #1 from techcorridorio/master

239fc2a

Merge pull request techcorridorio#32 from iLtc/master

Revert "Revert "Add dynamic "next meetup" to home page""

eab0b7b

So that I can get the code back~ This reverts commit cfc403a.

Remove debug code

0fb041e

Add date to the link text

e71a23a

benjaminoakes reviewed Feb 14, 2017

View reviewed changes

iLtc added 3 commits March 12, 2018 21:40

Merge remote-tracking branch 'upstream/master'

5189c44

Merge branch 'master' into next-meetup

948be99

Moved JS Code to meetup-events.js

0831c50

houndci-bot reviewed Mar 13, 2018

View reviewed changes

iLtc added 2 commits March 12, 2018 22:24

Moved '+' to the end of the line

a59a1b0

Changed ' to "

46cb714

houndci-bot reviewed Mar 13, 2018

View reviewed changes

+                          + (date.getHours() % 12) + ':'
+                          + (date.getMinutes() < 10 ? '0'+date.getMinutes() : date.getMinutes())
+                          + ' '
+                          + (date.getHours() < 12 ? 'AM' : 'PM');

+                          + ' at '
+                          + (date.getHours() % 12) + ':'
+                          + (date.getMinutes() < 10 ? '0'+date.getMinutes() : date.getMinutes())
+                          + ' '

+                          + date.getFullYear()
+                          + ' at '
+                          + (date.getHours() % 12) + ':'
+                          + (date.getMinutes() < 10 ? '0'+date.getMinutes() : date.getMinutes())

+                          + date.getDate() + ', '
+                          + date.getFullYear()
+                          + ' at '
+                          + (date.getHours() % 12) + ':'

+                  var months = [
+                      "January", "February", "March", "April",
+                      "May", "June", "July", "August",
+                      "September", "October", "November", "December"


		// Modify from _includes/meetup_cards.html

		window.onload = function(){

               </div>
+              {% raw  %}
+              <script type="text/javascript">

+                  //assume Mustache is loaded
+                  //assume Meetup is loaded
+                  // Modify from _includes/meetup_cards.html

+              };
+              var createEventParagraph = function (event) {
+                  var template = "Next meetup: <a href='{{event_url}}' target='_blank'>{{name}} ({{formattedShortDate}})</a>";

+                      return "http://maps.google.com/?q=" + encodeURI(venue.address_1) + '+' + encodeURI(venue.city);
+                  };
+                  var day = [ "Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"];

+              var EventPresenter = function(event) {
+                  var formatVenueLink = function(venue) {
+                      return "http://maps.google.com/?q=" + encodeURI(venue.address_1) + '+' + encodeURI(venue.city);

+                  var template = 'Next meetup: <a href=\'{{event_url}}\' target=\'_blank\'>' +
+              		           '{{name}} ({{formattedShortDate}})</a>';
+                  Mustache.parse(template);   // optional, speeds up future uses
+                  var rendered = Mustache.render(template, event);

Add dynamic "next meetup" to home page by iLtc · Pull Request #33 · techcorridorio/techcorridorio.github.io · GitHub

Uh oh!

Add dynamic "next meetup" to home page - #33

Add dynamic "next meetup" to home page#33iLtc wants to merge 9 commits intotechcorridorio:mastertechcorridorio/techcorridorio.github.io:masterfrom iLtc:next-meetupiLtc/techcorridorio.github.io:next-meetupCopy head branch name to clipboard

Conversation

iLtc commented Feb 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benjaminoakes commented Feb 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iLtc commented Mar 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add dynamic "next meetup" to home page#33
iLtc wants to merge 9 commits into
techcorridorio:masterfrom
iLtc:next-meetup