pyproject.toml: Removed protoc-wheel dependency - #684
Merged
cretz merged 2 commits intoNov 13, 2024
Merged
cretz merged 2 commits into
cretz merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
jpds
force-pushed
the
remove-protoc-wheel-requirement
branch
from
17afd7e to
c641686
Compare
November 6, 2024 14:41
jpds
force-pushed
the
remove-protoc-wheel-requirement
branch
from
c641686 to
f41ec84
Compare
November 6, 2024 14:42
cretz
approved these changes
Nov 12, 2024
cretz
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks! Yes I think we missed this. Will confirm CI passes, merge main back into your branch, and if CI passes again, will merge.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Removed protoc-wheel-0 dependency from pyproject.toml. I think this was missing from #547.
I needed to patch this out in the nixpkgs package to make the build succeed: 353720