Created TensorFormat enum by sevarac · Pull Request #191 · tensorflow/java · GitHub

Created enum for TensorFormat. Some additional enum values are open for discussion, at the moment there are values that are used by Tensorflow and cuDnn

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

I don't think we can look at PRs until the CLA has been signed, so that's what this is waiting on.

@googlebot I signed it др Зоран Шеварац | Zoran Ševarac, PhD Катедра за софтверско инжењерство | Department of Software Engineering Ванредни професор | Associate Professor [Fakultet organizacionih nauka] Универзитет у Београду | University of Belgrade Факултет организационих наука | Faculty of Organizational Sciences Јове Илића 154, Београд, Србија | Jove Ilića 154, Belgrade, Serbia t: +381 11 3950 853 e: zoran.sevarac@fon.bg.ac.rs<mailto:zoran.sevarac@fon.bg.ac.rs> w: http://www.fon.bg.ac.rs

…

________________________________ From: google-cla[bot] <notifications@github.com> Sent: Friday, January 22, 2021 2:37:36 PM To: tensorflow/java Cc: Zoran V. Ševarac; Author Subject: Re: [tensorflow/java] Created TensorFormat enum (#191) Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

________________________________ What to do if you already signed the CLA Individual signers * It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. Corporate signers * Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google/docs/cla/#troubleshoot>). * The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. * The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>. ℹ️ Googlers: Go here<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ftensorflow%2Fjava%2Fpull%2F191> for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#191 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABGTSKL2PBVDVJOWQRINRLS3F5SBANCNFSM4WOP2EMQ>.

Is there a reason we shouldn't add the other four enums as described in the link?

CHWN 4d tensor description
NCDHW 5d tensor description
NDHWC
CDHWN

The main question is are they are used by tensorflow at all? Maybe someone from Tensorflow team could answer this.
I've found these layouts in cuDNN documentation so there is good chance that they are used.
It would be best to add them too if they are used, otherwise not sure if it makes sense to add them

Thanks @sevarac , as we discussed briefly during our last session, this enum should probably be moved at the tensorflow-core-api or tensorflow-framework level. It would be helpful to know which one if you can provide some quick examples of usage. I think @JimClarke5 had some in mind too.

Sounds good, in general everywhere where public Options dataFormat(String dataFormat) is used
there should be now public Options dataFormat(TensorFormat dataFormat)
which includes a bunch of classes mainly layers https://github.com/tensorflow/java/search?q=dataFormat

It is used in losses.Losses for losses.CategoricalCrossentropy and metrics.CategoricalCrossentropy.

  public static final int CHANNELS_LAST = -1;
  public static final int CHANNELS_FIRST = 1;

Once this PR is merged, I'll change the logic in losses and metrics.

This could be done in the C++ op generator, by looking at any argument called dataFormat. Though I don't think this naming convention is enforced to the kernel developers, which might lead to mistakes. But there will be possible workarounds so I'm fine if you want to give a try making that change as well

Hi @sevarac , so any chance that you can move this enum to a different location, as I've suggested before?

If I need to pick one, I'll suggesttensorflow-framework over tensorflow-core-api, what about under org.tensorflow.framework.utils?

Also please don't forget to add the header notice in your file (like this one, for example).

BTW: I will also need this in layers.

Also please don't forget to add the header notice in your file (like this one, for example).

Created TensorFormat enum

b7f83bb

JimClarke5 reviewed Feb 4, 2021

View reviewed changes

karllessard reviewed Feb 11, 2021

View reviewed changes

karllessard requested changes Apr 5, 2021

View reviewed changes

JimClarke5 mentioned this pull request May 6, 2021

Layers phase 1 #318

Closed

JimClarke5 mentioned this pull request Jun 10, 2021

Reworked Layers Phase 1 #334

Open

		@@ -0,0 +1,30 @@
		package org.tensorflow.ndarray.buffer.layout;

Created TensorFormat enum by sevarac · Pull Request #191 · tensorflow/java · GitHub

Uh oh!

Created TensorFormat enum - #191

Created TensorFormat enum#191sevarac wants to merge 1 commit intotensorflow:mastertensorflow/java:masterfrom sevarac:mastersevarac/java:masterCopy head branch name to clipboard

Conversation

sevarac commented Jan 22, 2021

Uh oh!

google-cla Bot commented Jan 22, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Craigacp commented Jan 26, 2021

Uh oh!

sevarac commented Feb 1, 2021 via email

Uh oh!

JimClarke5 left a comment

Choose a reason for hiding this comment

Uh oh!

sevarac commented Feb 4, 2021

Uh oh!

karllessard Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

sevarac Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

JimClarke5 Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

karllessard Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karllessard Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

karllessard Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

JimClarke5 commented Mar 5, 2021

Uh oh!

karllessard Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Created TensorFormat enum#191
sevarac wants to merge 1 commit into
tensorflow:masterfrom
sevarac:master

karllessard Feb 16, 2021 •
edited
Loading