Callbacks phase 1 - #299
Conversation
Sorry, something went wrong.
Sync with master tensorflow on upstream
Merge main branch to local branch
Update after losses merge
Fix Javadoc errors (tensorflow#152)
pull type def
Metrics Phase 1 (tensorflow#180)
Pull latest tensorflow master
Merge with latest
Resync with origin/master
Sync with tensorflow/java master
Sync with Metrics Phase 2
Sync with master
Sync with Regularizers
|
|
||
| /** Creates a Callback */ | ||
| protected Callback() { | ||
| this(null); |
There was a problem hiding this comment.
Would it be better to use Collections.emptyMap() here rather than null? Or is it mutated?
Sorry, something went wrong.
There was a problem hiding this comment.
So far none of the subclasses write to it, so we could use emptyMap().
I don't think it is a good idea to leave it null. Also make it final in Callback.
Sorry, something went wrong.
| } | ||
|
|
||
| @Test | ||
| void onEpochEnd() {} |
There was a problem hiding this comment.
These tests are empty?
Sorry, something went wrong.
There was a problem hiding this comment.
I will fix
Sorry, something went wrong.
|
Mostly small stuff and some tidying in the docs. Otherwise it looks pretty good. |
Sorry, something went wrong.
Reviewers
Requested changes must be addressed to merge this pull request.
This is the first Phase of Callbacks and is just a minimal set to start work on Model.
There is a chicken and egg relationship with Callbacks and Model, so this PR just addresses the first part with integration with Model postponed. Only enough Callbacks to get started with Model are provided for now.
Once model is done, then a 2nd phase PR with full integration with Model will be created.