Apply spotless to generated files, exclude c api files - #359
Open
rnett wants to merge 5 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Also, when I run generation locally I get a bunch of new op classes like CacheDatasetV2 that are in ops.pb but don't seem to be generated in master, can anyone reproduce this? Did we at some point not push the new ops? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I also added a .gitattributes to set the line endings of most files to LF, since I was running into issues with it w/ the formatter when switching between Windows and Linux. Most of the generation code assumes that anyways. |
Sorry, something went wrong.
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
rnett
force-pushed
the
rn_fix_format
branch
from
fba95aa to
e9752f0
Compare
September 18, 2021 23:05
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says in the title. I can include the C API files if you want, but most of them (especially the presets) have special formatting by @saudet and I'm not sure if we want to override that.