FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Graph is changed to public in Session.java by manojava98 · Pull Request #535 · tensorflow/java · GitHub

Graph is changed to public in Session.java - #535

Merged
karllessard merged 4 commits into
tensorflow:masterfrom
manojava98:master
Apr 16, 2024
Merged

Graph is changed to public in Session.java#535
karllessard merged 4 commits into
tensorflow:masterfrom
manojava98:master

Conversation

Copy link
Copy Markdown
Contributor

made graph as public in sessions.java #479

made graph as public in sessions.java
Graph is changed to public in Update Session.java

google-cla Bot commented Apr 15, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

return graph;
}

private final Graph graph;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please @manojava98 , leave the field private and add a public getter named graph() to return that instance instead.

Copy link
Copy Markdown
Contributor Author

Hi @karllessard I have made the changes, kindly review it. Thanks

Copy link
Copy Markdown
Collaborator

Thanks @manojava98 !

karllessard merged commit 723bdcd into tensorflow:master Apr 16, 2024
karllessard added a commit that referenced this pull request Sep 24, 2024
* Graph is changed to public in Session.java (#535)

* Merge doc changes from r1.0

* Fix unknown shapes in signature proto

* Update NdArray dependency

* Fix spotless check

* Fix broadcastMask/Update

Accept partially unknown shaped mask

* linux-arm64: add build artifact item for linux-arm64 platform

TensorFlow v2.16.1 wheel artifacts and the jar build support are added

* linux-arm64 fixes to package the right dependencies into tensorflow native jar

* Fix javadoc

Co-authored-by: Adam Pocock <adam.pocock@oracle.com>

* Add instructions for new module names (#554)

* CI: add CI support for linux-arm64 platform (#548)

* Fix/javadoc script (#555)

* Update macos x86 runner

* Don’t deploy missing linux-arm64 build

* Cleanup missing Linux-arm64 dependencies

* Use org large runners for Linux arm64

* Using setup-java for linux-arm64

* Switch to zulu

* Add back Linux arm64 artifacts (#556)

* Upgrade to TF2.16.2 (#557)

* Link to libomp full name (#558)

* Releasing 1.0.0 RC2

---------

Co-authored-by: manojava98 <164733809+manojava98@users.noreply.github.com>
Co-authored-by: Sunita Nadampalli <nadampal@amazon.com>
Co-authored-by: Adam Pocock <adam.pocock@oracle.com>
Co-authored-by: snadampal <87143774+snadampal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL