FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

loading a2 rather than a0 by MustafaLotfi · Pull Request #11187 · tensorflow/models · GitHub

/ models Public

loading a2 rather than a0 - #11187

Merged
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
MustafaLotfi:master
Oct 23, 2024
ConversationCommits (1)ChecksFiles changed
Merged

loading a2 rather than a0#11187
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
MustafaLotfi:master

Conversation

MustafaLotfi commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

In the documentation that is provided for MoViNet tutorial, it says we will download MoViNet-A0-Stream. But In the code MoViNet-A2 is downloaded and used.

google-cla Bot commented Apr 4, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

review-notebook-app Bot commented Apr 4, 2024

Copy link
Copy Markdown

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

laxmareddyp requested review from Chen-Zhe and chaoyan1037 and removed request for rachellj218 and saberkun April 4, 2024 18:55

laxmareddyp commented Apr 4, 2024

Copy link
Copy Markdown
Collaborator

Hi @Chen-Zhe @chaoyan1037 ,

PR having typo changes , Please approve in your free time.Thanks

laxmareddyp added the models:official models that come under official repository label Apr 4, 2024

LakshmiKalaKadali commented Sep 16, 2024

Copy link
Copy Markdown
Collaborator

Hi @Chen-Zhe, @chaoyan1037,

Could you please review the PR.

Thank You

chaoyan1037 requested changes Sep 25, 2024
View reviewed changes

chaoyan1037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Instead of change comments, maybe update "load_movinet_from_hub('a2', 'stream', hub_version=3)" to be "load_movinet_from_hub('a0', 'stream', hub_version=3)" since the following section Export a Streaming Model to TensorFlow Lite for Mobile also use 'a0' as example.

MustafaLotfi commented Sep 26, 2024

Copy link
Copy Markdown
Contributor Author

@chaoyan1037
In the previous cells, MoViNet-A2-base is loaded and used, Wouldn't it be a better approach to use a same version (A2) for stream model too?

chaoyan1037 commented Oct 19, 2024

Copy link
Copy Markdown
Collaborator

I see.

chaoyan1037 self-requested a review October 19, 2024 18:42
laxmareddyp added the ready to pull ready to pull (create internal pr review and merge automatically) label Oct 19, 2024
copybara-service Bot merged commit 7ffafd0 into tensorflow:master Oct 23, 2024
copybara-service Bot pushed a commit that referenced this pull request Oct 23, 2024
Merge pull request #11187 from MustafaLotfi:master
86ded76 
PiperOrigin-RevId: 689031264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chaoyan1037 chaoyan1037 approved these changes
Chen-Zhe Awaiting requested review from Chen-Zhe

Assignees

No one assigned

Labels

models:official models that come under official repository ready to pull ready to pull (create internal pr review and merge automatically)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL