Reduce logs in EnvironmentAndSystemPropertyClientProviderStrate… - #1913
Merged
rnorth merged 1 commit intoSep 26, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ch risk leaking credentials on console output Fixes #1912
rnorth
force-pushed
the
santise-docker-client-provider-logs
branch
from
29cae0d to
94f73f8
Compare
September 25, 2019 15:09
bsideup
approved these changes
Sep 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove logs in EnvironmentAndSystemPropertyClientProviderStrategy which risk leaking credentials on console output
Fixes #1912
Before this change, docker registry credentials could be logged:
We recommend that you check recent CI logs for any accidentally logged credentials, and apologise for the inconvenience. Please see below for an example of the log message, which occurs during initial connection to the Docker daemon.
INFO o.t.d.DockerClientProviderStrategy - Found Docker environment with Environment variables, system properties and defaults. Resolved: dockerHost=unix:///var/run/docker.sock apiVersion='{UNKNOWN_VERSION}' registryUrl='https://index.docker.io/v1/' registryUsername='...' registryPassword='...' registryEmail='...' dockerConfig='DefaultDockerClientConfig[dockerHost= unix:///var/run/docker.sock,registryUsername=...,registryPassword=<...>, registryEmail=<...>,registryUrl=https://index.docker.io/v1/, dockerConfigPath=/home/user/.docker,sslConfig=<null>, apiVersion={UNKNOWN_VERSION},dockerConfig=<null>]'has been changed to: