Not really sure why it failed on CI, i will try to fix it during the weekend

Hey @slnowak,

Any luck?

@bsideup I've abandoned it because of lack of response. If you're still interested, I could resurrect the idea.

@slnowak you did a great job and for sure we wish to see the final result! :)

Do you need some help from our side?

I will try to find some time to work on it this week and give you some updates.

Great, thanks :)

@bsideup
Did some refactoring (lost almost all package private classes :(, but at least package structure is more readable now).
Tests should now pass on travis. However, I think it should be in a separate repo.

Hi @slnowak,

Looks impressive! I'll do my best to find time to re-review it soon 👍
I especially like the DSL part :)

If you want, I can create a repo under "testcontainers" org for you, so that you can put this module there and even take the ownership :)

We already did that for a couple of modules:
https://github.com/testcontainers/testcontainers-java-module-mariadb
https://github.com/testcontainers/testcontainers-java-module-dynalite
docker-archive-public/testcontainers.testcontainers-java-module-vault#1

Or we can do the merge and extract it ourselves. Just let me know what works best for you!

Thanks!

Reviewing and hoping to have a good play with this on a flight today. Looking pretty great so far though :)

@bsideup I will address the pr over the weekend + I will check how it behaves on multiple networks + stuff.

Sorry about the delay, I’m kind of busy during the week.

@slnowak no, we should be sorry for not reviewing it in time :D I'm assigning myself to this PR - feel free to ping me anytime (including Slack), let's deliver it 💪

@bsideup
Regarding pumba targets:
By default it interacts with all the containers running on docker, which is probably a no-go. I think we should restrict it only to containers spawned by testcontainers. Ideally, we should even restrict it to current tesctontainers session.
Unfortunately, there's not much we can do - see alexei-led/pumba#41 - you either need to play around with container names or you can annotate all the containers that should be ignored by pumba with --label com.gaiaadm.pumba.skip=true (which is of course not possible and not desirable).
Maybe we could submit a PR to pumba so that it takes requested labels into account?

We can also evaluate the regexp in java code and check at runtime if it matches any container that is started outside testcontainers, however it only partially solves the problem (in case of recurring command, it can affect any container started later than pumba)

Hi @slnowak,

Yes, a PR to Pumba sounds like the way to go 👍
Currently, they support "excludes" with com.gaiaadm.pumba.skip, and a PR might introduce "includes".

Ok, I will work on pumba PR in a day or two.

@slnowak thanks a lot for your efforts on bringing this! Amazing commitment 💪

For reference alexei-led/pumba#86
I've started some development to integrate this but let's wait for the pumba author's response.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

Let’s keep this one open!

Sent with GitHawk

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.

I'm afraid it's time to close this PR - sorry that we didn't manage to land it in the end.

We've just released a Toxiproxy module for resilience testing, which is arguably a less sophisticated model, but is much simpler from an implementation perspective.

I hope the Toxiproxy module meets the needs of anyone following this PR.

@slnowak thanks for your efforts, and sorry if you feel the work was in vain. Your idea, to be able to conduct chaos testing with Testcontainers, is still going to make a big difference for Testcontainers users and we're grateful for that.