Fix Guava shading in jdbc module - #399
Conversation
Sorry, something went wrong.
| <name>TestContainers Core</name> | ||
|
|
||
| <dependencies> | ||
| <dependency> |
There was a problem hiding this comment.
I moved it here, otherwise Maven would add it to every module as compile dependency. However, modules should use it from testcontainers dependency as a transitive.
Sorry, something went wrong.
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>18.0</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
Damn!
Sorry, something went wrong.
| <include>com.google.guava:*</include> | ||
| </includes> | ||
| </artifactSet> | ||
| <promoteTransitiveDependencies>false</promoteTransitiveDependencies> |
There was a problem hiding this comment.
This flag must be set to false to avoid including testcontainers' dependencies
Sorry, something went wrong.
rnorth
left a comment
There was a problem hiding this comment.
This looks fine for a quick fix. Still - I think we could probably quite easily remove the use of Guava altogether. Maybe something to do when we have a bit more time though.
Sorry, something went wrong.
1.4.0 introduced a bug in jdbc module. The shading was removed from it in #390, and Guava was in provided scope.