Don't run tests as part of the release build - #4600
Merged
kiview merged 1 commit intoOct 22, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
rnorth
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We just saw the release build fail because of lacking disk space to run the test suite as a whole:
https://github.com/testcontainers/testcontainers-java/runs/3975944533?check_suite_focus=true
BUILD FAILED in 1h 11m 13s java.lang.IllegalStateException: Check failed: Docker environment should have more than 2GB free disk spaceIn addition, the tests don't come from cache anymore and the whole build, therefore, takes unnecessary long, especially considering that we only release if we have a green master build.
This PR disables test execution during the release build.