| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I tried these failing tests locally, They work in all python versions (used venv) but were flaky and I had to try multiple time. |
Sorry, something went wrong.
|
@tillahoffmann Can you please review this change? |
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you for the addition! Some comments inline.
Sorry, something went wrong.
|
@tillahoffmann Thanks for the review comments. I have accommodated those in latest commit. |
Sorry, something went wrong.
|
assert consumer.end_offsets([tp])[tp] == 1, "Expected exactly one test message to be present on test topic !" This is going to ensure that we will have one and only one message in the consumer in integration test. |
Sorry, something went wrong.
I understand. Then it looks like the for loop and the assertion within don't add confidence to the test. Would you consider to scrap them? |
Sorry, something went wrong.
…d to provide correct feedback
|
@ash1425 Hey Ashay, do you have bandwidth working on the PR? If not, maybe I can help to cross the finish line? |
Sorry, something went wrong.
|
@YikSanChan For now, I have incorporated all the review comments and merged upstream changes to resolve the conflicts. I think we should be good to approve and merge if all tests pass. |
Sorry, something went wrong.
|
@ash1425 Great thanks! If there is any more comment from testcontainers members, I can try to resolve |
Sorry, something went wrong.
|
@tillahoffmann Could you please taking a look? This is the feature I am looking for. Thank you! |
Sorry, something went wrong.
|
@tillahoffmann CI seems happy. Are we good to get these changes in? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
fix #121 This PR adds support for kafka container. Heavily inspired from java testcontainer's Kafka module.