Fix deprecation warning message for ElasticsearchContainer - #171
Merged
tillahoffmann merged 2 commits intoApr 3, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tillahoffmann can you review this, please? |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 85.49% 85.51% +0.02%
==========================================
Files 25 25
Lines 655 656 +1
Branches 61 61
==========================================
+ Hits 560 561 +1
Misses 75 75
Partials 20 20
Continue to review full report at Codecov.
|
Sorry, something went wrong.
tillahoffmann
approved these changes
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I use ElasticsearchContainer class I get a "DeprecatedWarning: ElasticSearchContainer is deprecated" message which is wrong. This PR fixes this.