FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add support async postgres driver by fourteekey · Pull Request #320 · testcontainers/testcontainers-python · GitHub

/ testcontainers-python Public

add support async postgres driver - #320

Closed
fourteekey wants to merge 6 commits into
testcontainers:mainfrom
fourteekey:master
ConversationCommits (6)ChecksFiles changed
Closed

add support async postgres driver#320
fourteekey wants to merge 6 commits into
testcontainers:mainfrom
fourteekey:master

Conversation

fourteekey commented Mar 13, 2023

Copy link
Copy Markdown

No description provided.

fourteekey mentioned this pull request Mar 13, 2023
Open
pffijt linked an issue Mar 15, 2023 that may be closed by this pull request
Creating a Postgres contrainer with an async driver fails #263
Open
pffijt reviewed Mar 15, 2023
View reviewed changes
Comment thread core/testcontainers/core/generic.py Outdated
fourteekey requested a review from pffijt March 16, 2023 11:20

fourteekey commented Apr 5, 2023

Copy link
Copy Markdown
Author

@pffijt
Do you have any questions or comments about commits?

tillahoffmann suggested changes Apr 11, 2023
View reviewed changes

tillahoffmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the contribution. Added a few inline questions.

Comment thread postgres/setup.py Outdated
Comment thread postgres/testcontainers/postgres/__init__.py Outdated
Comment thread postgres/testcontainers/postgres/__init__.py
@wait_container_is_ready(*ADDITIONAL_TRANSIENT_ERRORS)
def _connect(self) -> None:
import sqlalchemy
engine = sqlalchemy.create_engine(self.get_connection_url(driver=self.DEFAULT_DRIVER))

tillahoffmann Apr 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we just use the super call here? It looks like the method body is the same as in the parent class (except for the driver argument which is already handled in the updated get_connection_url).

tillahoffmann May 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@fourteekey, could you please address this question?

tillahoffmann commented May 5, 2023

Copy link
Copy Markdown
Contributor

Unresolved some of the outstanding questions, @fourteekey. We'll also have to regenerate the lock files in requirements.txt. See step three of https://github.com/testcontainers/testcontainers-python#contributing-a-new-feature for details.

tillahoffmann mentioned this pull request May 5, 2023
Merged

fourteekey commented May 16, 2023

Copy link
Copy Markdown
Author

@tillahoffmann

All questions have been resolved.
I can't regenerate the lock files without approve, I got error: RuntimeError: Could not find a workflow. Has the GitHub Action run completed? If youare a first-time contributor, a contributor has to approve your changesbefore Actions can run.

Evgen4567 mentioned this pull request May 26, 2023
Closed

alexanderankin commented Mar 9, 2024

Copy link
Copy Markdown
Member

closing in favor of #445 because i believe it will handle this use case, let me know if this is not the case

jankatins mentioned this pull request Mar 10, 2024
Merged
alexanderankin pushed a commit that referenced this pull request Mar 10, 2024
feat(postgres): Remove SqlAlchemy dependency from postgres container (#…
f30eb1d 
…445)

Updates the pg testcontainer implementation to not use (and not install)
SQLAlchemy nor psycopg2.

Closes: #340
Closes: #336
Closes: #320

---------

Co-authored-by: Jason Turim <jason@opscanvas.com>
alexanderankin pushed a commit that referenced this pull request Mar 11, 2024
fix(postgres): Remove SqlAlchemy dependency from postgres container (#…
940167e 
…445)

Updates the pg testcontainer implementation to not use (and not install)
SQLAlchemy nor psycopg2.

Closes: #340
Closes: #336
Closes: #320

---------

Co-authored-by: Jason Turim <jason@opscanvas.com>
bearrito pushed a commit to bearrito/testcontainers-python that referenced this pull request Mar 30, 2024
feat(postgres): Remove SqlAlchemy dependency from postgres container (t…
0f79144 
…estcontainers#445)

Updates the pg testcontainer implementation to not use (and not install)
SQLAlchemy nor psycopg2.

Closes: testcontainers#340
Closes: testcontainers#336
Closes: testcontainers#320

---------

Co-authored-by: Jason Turim <jason@opscanvas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pffijt Awaiting requested review from pffijt
1 more reviewer
tillahoffmann tillahoffmann requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🚀 enhancement 📦 package: postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creating a Postgres contrainer with an async driver fails

4 participants

Back | FazBrowse Home | New Git URL