FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added MongoDb container by dabrign · Pull Request #47 · testcontainers/testcontainers-python · GitHub

/ testcontainers-python Public

Added MongoDb container - #47

Merged
SergeyPirogov merged 5 commits into
testcontainers:masterfrom
dabrign:master
Jan 10, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Added MongoDb container#47
SergeyPirogov merged 5 commits into
testcontainers:masterfrom
dabrign:master

Conversation

dabrign commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

No description provided.

codecov-io commented Jan 3, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #47 into master will decrease coverage by 0.28%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   84.93%   84.65%   -0.29%     
==========================================
  Files          17       18       +1     
  Lines         332      352      +20     
  Branches       20       20              
==========================================
+ Hits          282      298      +16     
- Misses         34       38       +4     
  Partials       16       16
Impacted Files Coverage Δ
testcontainers/mongodb.py 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ae58d...9c6d74e. Read the comment docs.

SergeyPirogov reviewed Jan 3, 2020
View reviewed changes
Comment thread tests/test_db_containers.py
assert row[0] == '10.2.9-MariaDB-10.2.9+maria~jessie'


@pytest.mark.skip(reason="needs oracle client libraries unavailable on Travis")

SergeyPirogov Jan 3, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is it commented?

dabrign Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I removed the comment in the last commit

tillahoffmann suggested changes Jan 5, 2020
View reviewed changes

tillahoffmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the addition! A few comments inline.

Comment thread testcontainers/mongodb.py
Comment thread tests/test_db_containers.py Outdated
"restaurant_id": "41704620"
}
)
print(result.inserted_id)

tillahoffmann Jan 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's remove print statements from tests.

dabrign Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done

tillahoffmann Jan 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like there's one more print statement lurking.

dabrign Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just removed!

Comment thread tests/test_db_containers.py Outdated
print(result.inserted_id)
cursor = db.restaurants.find({"borough": "Manhattan"})
for document in cursor:
print(document)

tillahoffmann Jan 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's remove this print statement and instead validate the document returned by iterating over the cursor.

dabrign Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done

dabrign commented Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

@SergeyPirogov @tillahoffmann I made the changes you suggested, please tell me if it's ok or other changes are needed.
Thanks

dabrign requested a review from tillahoffmann January 9, 2020 16:43
SergeyPirogov merged commit 4f97070 into testcontainers:master Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tillahoffmann tillahoffmann approved these changes
SergeyPirogov SergeyPirogov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL