fix: clean up reaper instances - #491
Closed
alexanderankin wants to merge 5 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
alexanderankin
added a commit
that referenced
this pull request
Mar 24, 2024
kiview
reviewed
Mar 25, 2024
Comment thread
core/tests/test_ryuk.py
| from testcontainers.core.waiting_utils import wait_for_logs | ||
|
|
||
|
|
||
| @pytest.mark.skip("invalid test - ryuk logs 'Removed' right before exiting") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why don't we remove the test if it is invalid?
I think the test should check, that the Ryuk container and the Docker container are gone in this case?
Sorry, something went wrong.
bearrito
pushed a commit
to bearrito/testcontainers-python
that referenced
this pull request
Mar 30, 2024
) fix testcontainers#489 , supercede testcontainers#491, testcontainers#498 Co-authored-by: Stefan Hoffmeister <stefan.hoffmeister@econos.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
suggest a fix for #489