chore(build): improve devcontainers setup with poetry - #506
Merged
totallyzen merged 5 commits intoMar 30, 2024
Merged
Conversation
4 tasks
Copy link
Copy Markdown
Member
|
i tested my new approach but i think it makes sense for you to see if it works for you, given that i dont use this all that much and may not be testing it the same way. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@alexanderankin No this is good, Much cleaner. I really just needed a way to get the completions in there. |
Sorry, something went wrong.
totallyzen
approved these changes
Mar 30, 2024
totallyzen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, thank you! ❤️
Sorry, something went wrong.
bearrito
added a commit
to bearrito/testcontainers-python
that referenced
this pull request
Mar 30, 2024
…#506) 1. Replaces uses an image directly. 2. Creates a custom image, still based off the original Image. 3. Installs poetry inside the container. This saves the user about 20 seconds every container load. 4. Installs `pre-commit` in the container. Saves more time. 5. Enables `pre-commit`. From inside the container the user cannot commit without `pre-commit` running. 6. Adds in git autocomplete to the container (see screenshot) 7. Adds in poetry autocomplete to the container (see screenshot)  --------- Co-authored-by: bstrausser <bstrausser@locusrobotics.com> Co-authored-by: David Ankin <daveankin@gmail.com> Co-authored-by: Bálint Bartha <39852431+totallyzen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.