FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(oracle): Remove unmaintained Oracle community module by santi · Pull Request #513 · testcontainers/testcontainers-python · GitHub

/ testcontainers-python Public

fix(oracle): Remove unmaintained Oracle community module - #513

Closed
santi wants to merge 2 commits into
mainfrom
remove/oracle-module
ConversationCommits (2)ChecksFiles changed
Closed

fix(oracle): Remove unmaintained Oracle community module#513
santi wants to merge 2 commits into
mainfrom
remove/oracle-module

Conversation

santi commented Mar 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

There are multiple problems with the current support for the Oracle module.

  • The author of the image seems to no longer maintain it
  • The original image (without the -r2 suffix was DMCA'd by Oracle from DockerHub. Not sure if the new one is actually compliant or if it has just gone under the radar.
  • The image uses an old build of Ubuntu 18.04 (which reached EOL in May 2023)
  • There is really nothing special in the setup and running of the image, which would not qualify for a community module currently (no wait strategy, almost no custom setup). An example code snippet would suffice in this case.
  • It does not support running on Apple Silicone, and requires client libraries to be installed to run in general.

Therefore, I suggest that we remove this module.

santi changed the title remove!: Remove unsupported Oracle community module remove!: Remove unmaintained Oracle community module Mar 30, 2024
santi changed the title remove!: Remove unmaintained Oracle community module fix!: Remove unmaintained Oracle community module Mar 30, 2024
santi changed the title fix!: Remove unmaintained Oracle community module fix(oracle): Remove unmaintained Oracle community module Mar 30, 2024

santi commented Mar 30, 2024

Copy link
Copy Markdown
Contributor Author

Just discovered this one: #363 Will check out it and similar ideas before moving forward with this one.

santi marked this pull request as draft March 30, 2024 20:27
totallyzen approved these changes Mar 30, 2024
View reviewed changes

totallyzen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As a general concept, if #363 doesn't work out, you've got my approval to remove. It's better to keep a healthy project than broken features.

This also comes back to "what level of guarantee do we have for community modules?" with this being a breaking change (or not) - either way, I approve the concept, but may want to wait with merging it for the correct semver identification

🙏

alexanderankin requested changes Mar 30, 2024
View reviewed changes

alexanderankin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

we have a PR to update oracle to mr. venzl's version, if we merge this, it gets harder to rebase that PR, please consider not merging, as i do have a plan for this module.

alexanderankin commented Mar 30, 2024

Copy link
Copy Markdown
Member

sorry, just saw the other newly opened PR, catching up still...

alexanderankin commented Mar 31, 2024

Copy link
Copy Markdown
Member

not necessary after #363

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alexanderankin alexanderankin requested changes
+1 more reviewer
totallyzen totallyzen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL