feat(oracle): Use Oracle Free image in Oracle module - #514
Closed
santi wants to merge 23 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
and not dbname Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
totallyzen
reviewed
Mar 30, 2024
Comment thread
modules/mysql/tests/test_mysql.py
Outdated
santi
commented
Mar 30, 2024
Comment thread
pyproject.toml
| neo4j = { version = "*", optional = true } | ||
| opensearch-py = { version = "*", optional = true } | ||
| cx_Oracle = { version = "*", optional = true } | ||
| oracledb = { version = "*", optional = true } |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This is only needed during testing, so should be included as a dev dependency, not as part of the extra.
Sorry, something went wrong.
santi
commented
Mar 30, 2024
Comment thread
pyproject.toml
| nginx = [] | ||
| opensearch = ["opensearch-py"] | ||
| oracle = ["sqlalchemy", "cx_Oracle"] | ||
| oracle = ["sqlalchemy", "oracledb"] |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Same as here, should only be a dev dependency (so that we don't include a lot of libs when installing TC)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@alexanderankin I took the liberty of opening a PR from your fork, as I didn't want to copy your work when you were almost at the finish line. Just a few comments regarding MySQL and some dependencies, and you have a thumbs up from me 👍 Judging from some reactions over at #363, this is a useful module |
Sorry, something went wrong.
alexanderankin
force-pushed
the
gvenzl_main
branch
2 times, most recently
from
ea04fc0 to
22e876e
Compare
March 31, 2024 04:26
alexanderankin
force-pushed
the
gvenzl_main
branch
3 times, most recently
from
b095c65 to
76bcb95
Compare
March 31, 2024 06:16
alexanderankin
force-pushed
the
gvenzl_main
branch
4 times, most recently
from
e7bb9bf to
235e96b
Compare
March 31, 2024 06:39
alexanderankin
force-pushed
the
gvenzl_main
branch
2 times, most recently
from
9eecb48 to
5da1e94
Compare
March 31, 2024 06:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple problems with the current support for the Oracle module.
By switching over to Oracle Free image as our base image, we get an up-to-date image which is maintained on a modern Oracle version.