fix: added types to exec & tc_properties_get_tc_host - #561
Conversation
Sorry, something went wrong.
errordeveloper
left a comment
There was a problem hiding this comment.
this LGTM overall, thanks @Dandiggas!
Sorry, something went wrong.
|
@kiview could you please approve the workflows to run? |
Sorry, something went wrong.
|
We'll take a look |
Sorry, something went wrong.
|
yep so we support python 3.9 for now so cant use the pipe syntax for typing.Union - but the other type is indeed wrong so we could merge a pr that just fixes a single type, would probably prefer a PR that fixes types more comprehensively like #504 - if you want to provide feedback on that branch, that could help it along - it was only not merged because i was not confident in 100% of the choices made in there at the time. ill leave this open in case you want to replace with from typing import Union |
Sorry, something went wrong.
|
@alexanderankin Now supports python 3.9, please review when possible |
Sorry, something went wrong.
|
thank you for the contribution! if you are interested in improving typing in this library are other types that I have started but did not feel confident enough to merge #504 |
Sorry, something went wrong.
🤖 I have created a release *beep* *boop* --- ## [4.5.0](testcontainers-v4.4.1...testcontainers-v4.5.0) (2024-05-25) ### Features * **core:** Private registry ([#566](#566)) ([59fbcfa](59fbcfa)) ### Bug Fixes * added types to exec & tc_properties_get_tc_host ([#561](#561)) ([9eabb79](9eabb79)) * on windows, DockerCompose.get_service_host returns an unusable "0.0.0.0" - adjust to 127.0.0.1 ([#457](#457)) ([2aa3d37](2aa3d37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [4.5.0](testcontainers/testcontainers-python@testcontainers-v4.4.1...testcontainers-v4.5.0) (2024-05-25) ### Features * **core:** Private registry ([testcontainers#566](testcontainers#566)) ([59fbcfa](testcontainers@59fbcfa)) ### Bug Fixes * added types to exec & tc_properties_get_tc_host ([testcontainers#561](testcontainers#561)) ([9eabb79](testcontainers@9eabb79)) * on windows, DockerCompose.get_service_host returns an unusable "0.0.0.0" - adjust to 127.0.0.1 ([testcontainers#457](testcontainers#457)) ([2aa3d37](testcontainers@2aa3d37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#557 - trying to solve this issue by adding types.