fix(core): Typing in docker_client by Tranquility2 · Pull Request #702 · testcontainers/testcontainers-python · GitHub

poetry run mypy --config-file pyproject.toml core/testcontainers/core/docker_client.py 
Success: no issues found in 1 source file

Old

                    Error Summary                     
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┓
┃ File Path                                 ┃ Errors ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━┩
│ core/testcontainers/core/version.py       │ 12     │
│ core/testcontainers/core/docker_client.py │ 14     │
│ core/testcontainers/core/image.py         │ 17     │
│ core/testcontainers/core/waiting_utils.py │ 8      │
│ core/testcontainers/core/container.py     │ 20     │
│ core/tests/test_new_docker_api.py         │ 4      │
│ core/tests/test_docker_in_docker.py       │ 2      │
│ core/testcontainers/compose/compose.py    │ 22     │
│ core/testcontainers/compose/__init__.py   │ 2      │
│ core/tests/test_version.py                │ 2      │
│ core/tests/test_ryuk.py                   │ 2      │
│ core/tests/test_registry.py               │ 1      │
│ core/tests/test_image.py                  │ 3      │
│ core/tests/test_compose.py                │ 7      │
└───────────────────────────────────────────┴────────┘
Found 116 errors in 14 files.

New

                    Error Summary                     
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┓
┃ File Path                                 ┃ Errors ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━┩
│ core/testcontainers/core/version.py       │ 12     │
│ core/testcontainers/core/network.py       │ 3      │
│ core/testcontainers/core/image.py         │ 17     │
│ core/testcontainers/core/waiting_utils.py │ 8      │
│ core/testcontainers/core/container.py     │ 19     │
│ core/tests/test_new_docker_api.py         │ 4      │
│ core/tests/test_docker_in_docker.py       │ 2      │
│ core/testcontainers/compose/compose.py    │ 22     │
│ core/testcontainers/compose/__init__.py   │ 2      │
│ core/tests/test_version.py                │ 2      │
│ core/tests/test_ryuk.py                   │ 2      │
│ core/tests/test_registry.py               │ 1      │
│ core/tests/test_image.py                  │ 3      │
│ core/tests/test_compose.py                │ 7      │
└───────────────────────────────────────────┴────────┘
Found 104 errors in 14 files.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e9e40f9). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage        ?   84.97%           
=======================================
  Files           ?       12           
  Lines           ?      679           
  Branches        ?      106           
=======================================
  Hits            ?      577           
  Misses          ?       79           
  Partials        ?       23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Please note:

core/testcontainers/core/config.py:46: error: X | Y syntax for unions requires Python 3.10  [syntax]
        connection_mode: str | None = environ.get("TESTCONTAINERS_CONNECTION_MODE")

Found when rebasing and updated to support 3.9 (I'm not aware of deprecating 3.9 in tc-python, feel free to update)

@alexanderankin @kiview can you please rerun this? (I assume this was an issue with the docker registry)

Please use cast only when required (i.e. for dict[str, Any]).

If possible always improve the runtime type safety.

Suggested change

      
                    if cast(str, self) == self.bridge_ip:
          
                    if self == self.bridge_ip:

That is neither required nor correct.

The original code does not issue any Typing Errors:
Not in mypy nor pyright

@CarliJoy Mypy seems to disagree:

Update to latest mypy, still the same behavior
mypy 1.15.0 (compiled: yes)

Found the issue :)
under "[tool.mypy]" on pyproject.toml
we have strict = true

I'll be adding # type: ignore[comparison-overlap] in the relevant locations (future PRs) @CarliJoy

Fixed

if self == ConnectionMode.bridge_ip:

Seems to be the type correct solution.

Will fix after #807 as it also touch this part :)

@CarliJoy apricate you taking the time to comment :) I'll be happy to fix and update as suggested.
I assume/hope #700 & #701 will go in first so I'll know we are really rolling with this track.

@CarliJoy Updated with all of the Fixes

🤖 I have created a release *beep* *boop* --- ## [4.11.0](testcontainers-v4.10.0...testcontainers-v4.11.0) (2025-06-15) ### Features * **core:** Protocol support for container port bind and expose ([#690](#690)) ([a0d4317](a0d4317)) * DockerContainer initializer to accept its private members as kwargs ([#809](#809)) ([e7feb53](e7feb53)) ### Bug Fixes * **compose:** use provided docker command instead of default ([#785](#785)) ([0ae704a](0ae704a)) * **core:** Add kwargs to image build ([#708](#708)) ([cc02f94](cc02f94)) * **core:** change with_command type to include list of strings ([#789](#789)) ([f7c29cb](f7c29cb)) * **core:** Determine docker socket for rootless docker ([#779](#779)) ([6817582](6817582)) * **core:** Typing in docker_client ([#702](#702)) ([e8bf224](e8bf224)) * **core:** Typing in generic + network ([#700](#700)) ([2061912](2061912)) * **core:** Typing in version ([#701](#701)) ([9dc2a02](9dc2a02)) * **core:** wait in test core registry ([#812](#812)) ([b574c0e](b574c0e)) * **modules:** fix cosmosdb failure ([#827](#827)) ([dafcbed](dafcbed)) * **modules:** update chroma version ([#826](#826)) ([b7d41dd](b7d41dd)) * **rabbitmq:** correct pika pypi reference ([#817](#817)) ([e90d308](e90d308)) * **registry:** module typed ([#811](#811)) ([6b11268](6b11268)) * use connection mode override function in config ([#775](#775)) ([ab2a1ab](ab2a1ab)), closes [#774](#774) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(core): Typed docker_client

781dec3

Tranquility2 changed the title fix(core): Typed docker_client fix(core): Typing in docker_client Sep 16, 2024

Tranquility2 mentioned this pull request Oct 2, 2024

feat(core): add buildargs to DockerImage #614

Closed

alexanderankin added the 👀 intend to merge this or some version of it label Nov 11, 2024

Tranquility2 closed this Nov 16, 2024

Tranquility2 reopened this Nov 16, 2024

Fix issues from recent merges

993696a

CarliJoy suggested changes Feb 28, 2025

View reviewed changes

Tranquility2 added 2 commits March 15, 2025 10:35

Fix comparison-overlap check for config

e9e8c2f

CR fixes

7b69f50

Tranquility2 force-pushed the typed_docker_client branch from f4b0d0a to 59372c6 Compare March 15, 2025 10:53

Tranquility2 requested a review from CarliJoy March 15, 2025 10:58

alexanderankin force-pushed the typed_docker_client branch from 0c70979 to 7b69f50 Compare May 4, 2025 17:45

alexanderankin approved these changes May 4, 2025

View reviewed changes

alexanderankin merged commit e8bf224 into testcontainers:main May 4, 2025

github-actions Bot mentioned this pull request May 4, 2025

chore(main): release testcontainers 4.11.0 #800

Merged

	if cast(str, self) == self.bridge_ip:
	if self == self.bridge_ip:

fix(core): Typing in docker_client by Tranquility2 · Pull Request #702 · testcontainers/testcontainers-python · GitHub

Uh oh!

fix(core): Typing in docker_client - #702

fix(core): Typing in docker_client#702alexanderankin merged 4 commits intotestcontainers:maintestcontainers/testcontainers-python:mainfrom Tranquility2:typed_docker_clientTranquility2/testcontainers-python:typed_docker_clientCopy head branch name to clipboard

Conversation

Tranquility2 commented Sep 16, 2024

Uh oh!

codecov Bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Tranquility2 commented Nov 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tranquility2 commented Dec 14, 2024

Uh oh!

CarliJoy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CarliJoy Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

Tranquility2 Mar 15, 2025

Choose a reason for hiding this comment

Uh oh!

Tranquility2 Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tranquility2 Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tranquility2 Mar 15, 2025

Choose a reason for hiding this comment

Uh oh!

CarliJoy Mar 15, 2025

Choose a reason for hiding this comment

Uh oh!

Tranquility2 Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Tranquility2 commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tranquility2 commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(core): Typing in docker_client#702
alexanderankin merged 4 commits into
testcontainers:mainfrom
Tranquility2:typed_docker_client

codecov Bot commented Sep 16, 2024 •
edited
Loading

Tranquility2 commented Nov 16, 2024 •
edited
Loading

Tranquility2 Mar 15, 2025 •
edited
Loading

Tranquility2 Mar 15, 2025 •
edited
Loading

Tranquility2 commented Mar 8, 2025 •
edited
Loading

Tranquility2 commented Mar 15, 2025 •
edited
Loading