FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(trino): Remove deprecated class and decorator from Trino container by andythsu · Pull Request #895 · testcontainers/testcontainers-python · GitHub

/ testcontainers-python Public

fix(trino): Remove deprecated class and decorator from Trino container #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tranquility2 merged 2 commits into from
Oct 4, 2025
Conversation 1 Commits 2 Checks 16 Files changed
Merged

fix(trino): Remove deprecated class and decorator from Trino container #895

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4b9e4
Remove deprecated class and decorator from Trino container
andythsu Oct 3, 2025
09a8c8d
Merge branch 'main' into fix_trino
Tranquility2 Oct 4, 2025
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
29 changes: 8 additions & 21 deletions modules/trino/testcontainers/trino/__init__.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -13,41 +13,28 @@
import re

from testcontainers.core.config import testcontainers_config as c
from testcontainers.core.generic import DbContainer
from testcontainers.core.waiting_utils import wait_container_is_ready, wait_for_logs
from trino.dbapi import connect
from testcontainers.core.generic import DockerContainer
from testcontainers.core.wait_strategies import LogMessageWaitStrategy


class TrinoContainer(DbContainer):
class TrinoContainer(DockerContainer):
def __init__(
self,
image="trinodb/trino:latest",
user: str = "test",
port: int = 8080,
container_start_timeout: int = 30,
**kwargs,
):
super().__init__(image=image, **kwargs)
self.user = user
self.port = port
self.with_exposed_ports(self.port)

@wait_container_is_ready()
def _connect(self) -> None:
wait_for_logs(
self,
re.compile(".*======== SERVER STARTED ========.*", re.MULTILINE).search,
c.max_tries,
c.sleep_time,
)
conn = connect(
host=self.get_container_host_ip(),
port=self.get_exposed_port(self.port),
user=self.user,
self.waiting_for(
LogMessageWaitStrategy(re.compile(".*======== SERVER STARTED ========.*", re.MULTILINE))
.with_poll_interval(c.sleep_time)
.with_startup_timeout(container_start_timeout)
)
cur = conn.cursor()
cur.execute("SELECT 1")
cur.fetchall()
conn.close()

def get_connection_url(self):
return f"trino://{self.user}@{self.get_container_host_ip()}:{self.port}"
Expand Down
Loading
Back | FazBrowse Home | New Git URL