feat(core): Add run_containers function in utils.py to run several containers - #896
feat(core): Add run_containers function in utils.py to run several containers#896surister wants to merge 1 commit into
Conversation
Sorry, something went wrong.
…containers at the same time
|
if we add this can we name it consistently with any one of the other implementations, thanks |
Sorry, something went wrong.
Hm, could you like any of the other implementations? Can't find them @alexanderankin |
Sorry, something went wrong.
|
I'm admittedly not sure this should be part of the library, when the caller can achieve the same result explicitly with the same amount of code. with run_containers(
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network),
) as containers:
c1, c2 = containers
Becomes with contextlib.ExitStack() as stack:
c1, c2 = stack.enter_context(container) for container in (
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network)
)
|
Sorry, something went wrong.
|
… On Mon, Oct 13, 2025 at 5:23 PM Ryan Hoban ***@***.***> wrote:
*rhoban13* left a comment (testcontainers/testcontainers-python#896)
<#896 (comment)>
I'm admittedly not sure this should be part of the library, when the
caller can achieve the same result explicitly with the same amount of code.
with run_containers(
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network),
) as containers:
c1, c2 = containers
Becomes
with contextlib.ExitStack() as stack:
c1, c2 = stack.enter_context(container) for container in (
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network)
)
—
Reply to this email directly, view it on GitHub
<#896 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACECGJEPB3G3BZVLOQQEFKT3XQJ3PAVCNFSM6AAAAACIKPW4UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJZGEYDQNZSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sorry, something went wrong.
|
… On Tue, Oct 14, 2025 at 8:23 PM David Ankin ***@***.***> wrote:
https://www.javadoc.io/doc/org.testcontainers/testcontainers/1.12.1/org/testcontainers/lifecycle/Startables.html
On Mon, Oct 13, 2025 at 5:23 PM Ryan Hoban ***@***.***>
wrote:
> *rhoban13* left a comment (testcontainers/testcontainers-python#896)
> <#896 (comment)>
>
> I'm admittedly not sure this should be part of the library, when the
> caller can achieve the same result explicitly with the same amount of code.
>
> with run_containers(
> PostgresContainer(network=network),
> PostgresContainer(image='postgres:16', network=network),
> ) as containers:
> c1, c2 = containers
>
> Becomes
>
> with contextlib.ExitStack() as stack:
> c1, c2 = stack.enter_context(container) for container in (
> PostgresContainer(network=network),
> PostgresContainer(image='postgres:16', network=network)
> )
>
> —
> Reply to this email directly, view it on GitHub
> <#896 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACECGJEPB3G3BZVLOQQEFKT3XQJ3PAVCNFSM6AAAAACIKPW4UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJZGEYDQNZSGE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sorry, something went wrong.
|
Ahhhh, I see what you're looking to achieve. I could definitely see the parallel container startup being a really useful feature. In it's current form, that's not what this PR proposes. I suspect such an implementation and would warrant some discussion on which of python's plethora of ways to achieve parallelism makes most sense here. |
Sorry, something went wrong.
This utils method runs containers on the same context manager. This ensures that the passed containers are run in order and cleaned up.
The main use case is to be able to run code after all containers have started. I need this to create CrateDB clusters.
Practical example: run containers inside a network and clean up the network (network can only be cleaned up after all containers using it are stopped)