FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(mongodb): Use wait strategy instead of deprecated wait_for_logs by pmorch · Pull Request #943 · testcontainers/testcontainers-python · GitHub

/ testcontainers-python Public

fix(mongodb): Use wait strategy instead of deprecated wait_for_logs #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderankin merged 2 commits into from
Jun 3, 2026
Conversation 1 Commits 2 Checks 10 Files changed
Merged

fix(mongodb): Use wait strategy instead of deprecated wait_for_logs #943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d55384
fix(mongodb): Use wait strategy instead of deprecated wait_for_logs
pmorch Dec 27, 2025
468ddb5
Merge branch 'main' into fix/mongodb-deprecated-wait-strategy
alexanderankin Jun 3, 2026
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
20 changes: 10 additions & 10 deletions modules/mongodb/testcontainers/mongodb/__init__.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@

from testcontainers.core.generic import DbContainer
from testcontainers.core.utils import raise_for_deprecated_parameter
from testcontainers.core.wait_strategies import HealthcheckWaitStrategy
from testcontainers.core.waiting_utils import wait_for_logs

from testcontainers.core.wait_strategies import HealthcheckWaitStrategy, LogMessageWaitStrategy

class MongoDbContainer(DbContainer):
"""
Expand Down Expand Up @@ -58,7 +56,13 @@ def __init__(
**kwargs,
) -> None:
raise_for_deprecated_parameter(kwargs, "port_to_expose", "port")
super().__init__(image=image, **kwargs)
super().__init__(
image=image,
_wait_strategy=LogMessageWaitStrategy(
re.compile(r"waiting for connections", re.IGNORECASE)
),
**kwargs,
)
self.username = username if username else os.environ.get("MONGO_INITDB_ROOT_USERNAME", "test")
self.password = password if password else os.environ.get("MONGO_INITDB_ROOT_PASSWORD", "test")
self.dbname = dbname if dbname else os.environ.get("MONGO_DB", "test")
Expand All @@ -79,12 +83,8 @@ def get_connection_url(self) -> str:
)

def _connect(self) -> None:
regex = re.compile(r"waiting for connections", re.MULTILINE | re.IGNORECASE)

def predicate(text: str) -> bool:
return regex.search(text) is not None

wait_for_logs(self, predicate)
# LogMessageWaitStrategy handles waiting for container readiness
pass

def get_connection_client(self) -> MongoClient:
return MongoClient(self.get_connection_url())
Expand Down
Loading
Back | FazBrowse Home | New Git URL