| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Before I start adding tests, what do you think about this? Cc @kentcdodds
|
Sorry, something went wrong.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c546d52:
|
Sorry, something went wrong.
|
Honestly, I think this would be a worthwhile thing in all the queries and eventually should be enabled by default (which of course would be a breaking change). |
Sorry, something went wrong.
There was a problem hiding this comment.
Why not use the same name for the option as ByRole does?
Also note that this has considerable perf impact. ByText etc are a faster, less accurate helper and with this change we're making the distinction between By* and ByRole less clear.
Sorry, something went wrong.
|
I think that's fair @eps1lon. As I'm no longer maintaining Testing Library, I don't think it's fair for me to make decisions here. I think the best would be to have this supported in all the queries and the "faster, less accurate helper" can be offered by using the option. |
Sorry, something went wrong.
|
I'm not fundamentally opposed. But the added dimension due to the naming of the option is a bigger concern for me right now. |
Sorry, something went wrong.
|
Oh, yeah, I agree we should probably keep the names consistent 👍 |
Sorry, something went wrong.
|
I used different name to avoid confusion with *ByRole as that hidden: true there means to show hidden as well |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What: add excludeHidden option for *ByText queries
Why: #196
How: used the already existing isInaccessible function
Checklist:
docs site