FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Finer custom fields match by bloatware · Pull Request #792 · textpattern/textpattern · GitHub

Finer custom fields match - #792

Open
bloatware wants to merge 23 commits into
devfrom
bloatware-patch-2
Open

Finer custom fields match#792
bloatware wants to merge 23 commits into
devfrom
bloatware-patch-2

Conversation

Copy link
Copy Markdown
Member

With pgonly="1" <txp:article_custom /> will output the number of matching articles pages, without setting the pagination.

With pgonly="1" <txp:article_custom /> will output the number of matching articles pages, without setting the pagination.

makss commented Oct 3, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

It seems already been attempts to add pgonly attribute to article_custom tag.

Copy link
Copy Markdown
Member Author

It seems already been attempts to add pgonly attribute to article_custom tag.

Sure, including mine, few years ago :-) It didn't get much attention, but I'm not desperate. The aim is to be able to easily count pages or articles (with pageby="1") for informational purposes or for use in pagination plugins.

bloatware mentioned this pull request Nov 11, 2016
bloatware changed the title Enable pageby and pgonly for <txp:article_custom /> tag Finer custom fields match Nov 12, 2016

Copy link
Copy Markdown
Member Author

The initial patch (enable pages count for article_custom) is merged into dev now. The rest of this branch allows for finer custom fields match in article(_custom) and related_articles.

Bloke commented Dec 28, 2016

Copy link
Copy Markdown
Member

Although I haven't tested it, this seems like a pretty good idea to me. Is it okay to be merged? Any backwards-compatibility issues?

Regarding the item attribute: it assumes comma is the separator. But an earlier commit references pipe also. Should we introduce a separator attribute here, like there is for the if_custom_field tag, so that people are free to delimit their custom fields in any way they see fit? Or is that too confusing?

Copy link
Copy Markdown
Member Author

Thanks @Bloke. I thought we should postpone it to the unlimited custom fields era, also because separator could then become part of custom field definition.

bloatware added this to the v4.8 milestone Jan 19, 2017
petecooper modified the milestones: v4.8, v4.9 Nov 28, 2019
petecooper removed this from the v4.9 milestone Dec 2, 2020
bumping readme to have parity with `dev`
tweak top matter

Copy link
Copy Markdown
Member

Paging @bloatware – what's the status of this branch / PR from your viewpoint? The branch reports as 20 commits ahead of dev, are those commits worth evaluating for inclusion in dev, or would you prefer it be left open?

Copy link
Copy Markdown
Member Author

@petecooper this branch will be superseded by cf, so eventually including it in dev is only worth considering if dev and cf will not merge in a near future. But I hope they will and would keep this one aside.

Copy link
Copy Markdown
Member

Thanks @bloatware – makes perfect sense.

readme parity

bloatware left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @petecooper, will merge after 4.8.8 freeze.

Updated version numbers and download links for Textpattern. Changed upgrade instructions to reference UPGRADE.txt. Added additional development tools section.
Document additional development tools and usage instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL