FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adds cover image (and other small things) by Loquacity · Pull Request #63 · thegooddocsproject/thegooddocsproject.github.io · GitHub

This repository was archived by the owner on Apr 22, 2021. It is now read-only.
/ thegooddocsproject.github.io Public archive

Adds cover image (and other small things) - #63

Open
Loquacity wants to merge 5 commits into
thegooddocsproject:masterfrom
Loquacity:iaguide-addimage-loquacity
ConversationCommits (5)ChecksFiles changed
Open

Adds cover image (and other small things)#63
Loquacity wants to merge 5 commits into
thegooddocsproject:masterfrom
Loquacity:iaguide-addimage-loquacity

Conversation

Loquacity commented Nov 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

ALL Pull-Requests require an associated Issue as documented in How to contribute.

Fixes: thegooddocsproject/templates#173

Purpose / why

Adds an image to the cover of the interactive IA Guide

What changes were made?

  • Adds .svg and .png images to the images directory, and links it to the cover page of the interactive IA Guide.
  • Slight modifications to the GH Action to make it run effectively when a PR is created from a fork.
  • Adds a short note to the twine file for future contributors.

Verification

  • Check that the image is appropriate
  • Check that the image appears correctly.
  • Ensure checks have passed

Checklist

Pull-request reviewer should ensure the following

  • Are issues linked correctly?
  • Is this PR labeled correctly?
  • If template updates: do they align with developers.google.com/style/?
  • Did the PR receive at least one 👍 and no 👎 from core-maintainers?
  • On merging, did you complete the merge using keywords?
  • On merging, did you add any applicable notes to a draft release and link to this PR?

Loquacity commented Nov 29, 2020

Copy link
Copy Markdown
Member Author

@mgan59 I think the action won't run because I've proposed from a fork, rather than a direct branch. Can we adjust the action so that works, or is this a limitation of GH Actions?

Loquacity commented Nov 29, 2020

Copy link
Copy Markdown
Member Author

@mgan59 I think the action won't run because I've proposed from a fork, rather than a direct branch. Can we adjust the action so that works, or is this a limitation of GH Actions?

I might have answered my own question. According to https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ I need to change the action to run on: [pull_request_target]. Let me try that.

Loquacity changed the title Adds cover image Adds cover image (and other small things) Nov 29, 2020
Loquacity requested a review from camerons March 1, 2021 04:06
camerons suggested changes Mar 27, 2021
View reviewed changes

camerons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So I've taken so long to review this, that this website repo has become deprecated, replaced by the hugo-website repo.

Lana, if there is anything of value in this pull request, I suggest that you re-apply it to the hugo-website repo.

Sorry for the slow review, and resulting extra work caused. I'll commit to review within a couple of weeks if you redo this in the hugo repo (and tell me of it).

I'll leave it to you Lana to decide whether you want this review approved here as well, but I'd suggest this request should be closed out with no action.

Loquacity commented Mar 29, 2021

Copy link
Copy Markdown
Member Author

I don't have the time to handle this right now, sorry. Feel free to close it. If someone wants to take these images and add them to the new site, I'm happy for them to do so.

camerons added the good first issue Good for newcomers label Mar 29, 2021

camerons commented Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This is a good first time issue for someone who wants to learn how to use git.
Look at these changes that Loquacity has recommended in this legacy repository thegooddocsproject.github.io and copy the changes across to https://github.com/thegooddocsproject/website-hugo

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

jaredmorgs Awaiting requested review from jaredmorgs
mgan59 Awaiting requested review from mgan59
1 more reviewer
camerons camerons requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IA Guide - Add cover image

2 participants

Back | FazBrowse Home | New Git URL