Stop installing the dotenv console script on a plain pip install - #689
Open
gyanu2507 wants to merge 1 commit into
Open
Stop installing the dotenv console script on a plain pip install#689gyanu2507 wants to merge 1 commit into
gyanu2507 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
A conda/venv install without the cli extra was dropping a stub `dotenv` on PATH that hid a working user-level python-dotenv[cli]. Drive the CLI with python -m dotenv instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The [cli] extra is supposed to be what gives you the CLI, but the wheel always installed a dotenv script. That script then died with "not installed with cli option" if click wasn't in that environment.
In the setup from #683 that's the conda env's stub winning over a user-level python-dotenv[cli]. Pip installs the same wheel for both extras, so the script cannot actually be extra-gated. Dropping it from the base package and using python -m dotenv (after pip install python-dotenv[cli]) is the option that doesn't leave a fake command on PATH.
__main__.py still reports itself as dotenv so --version output stays the same.
Fixes #683