FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updating getParameter docblock by funkjedi · Pull Request #85 · thunderer/Shortcode · GitHub

Updating getParameter docblock - #85

Merged
thunderer merged 2 commits into
thunderer:masterfrom
funkjedi:patch-1
Mar 8, 2020
Merged

Updating getParameter docblock#85
thunderer merged 2 commits into
thunderer:masterfrom
funkjedi:patch-1

Conversation

funkjedi commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

Current @param value of null results in a PhanTypeMismatchArgument error when analyzing code that implements the interface with phan.

CollectionsShortcode.php:19 PhanTypeMismatchArgument Argument 2 ($default) is false but \Thunder\Shortcode\Shortcode\ShortcodeInterface::getParameter() takes null defined at vendor/thunderer/shortcode/src/Shortcode/ShortcodeInterface.php:41

Current param value of null results in a PhanTypeMismatchArgument error when analyzing app with phan.
Comment thread src/Shortcode/ShortcodeInterface.php Outdated
thunderer added the patch label Mar 7, 2020
thunderer merged commit 79a219f into thunderer:master Mar 8, 2020
funkjedi deleted the patch-1 branch March 8, 2020 11:31

Copy link
Copy Markdown
Owner

@funkjedi released v0.7.4. Thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL