| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Merge in tiangolo/master
Aligning with tiangolo master
|
Thanks! That looks like a small change with a long time debugging and investigating 🤓 Were you able to test it? Did it solve the problem? |
Sorry, something went wrong.
|
Hi @tiangolo , I do not have a reproductible test, yet here is what I have done:
I have also checked the logs, and there are no more OperationalErrors after applying the fix (I will check again during the week) From my point of view, the issue is fixed, but not automatically tested. Which does not really concern me, since the management of the connection cool is on the SQLAlchemy level, and therefore tested by them |
Sorry, something went wrong.
|
Cool! Thanks for the explanation and the local tests you did. That's good enough ✔️ Thanks for your work! 🎉 🚀 🍰 |
Sorry, something went wrong.
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
| Back | FazBrowse Home | New Git URL |
Details of the bug can be found in issue #31
The solution makes use of the 'pessimistic' approach as described in https://docs.sqlalchemy.org/en/13/core/pooling.html#pool-disconnects