FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove padding from borderless menus by Mr-Neutr0n · Pull Request #5447 · tmux/tmux · GitHub

/ tmux Public

Remove padding from borderless menus - #5447

Open
Mr-Neutr0n wants to merge 2 commits into
tmux:masterfrom
Mr-Neutr0n:fix/menu-border-lines-none
Open

Remove padding from borderless menus#5447
Mr-Neutr0n wants to merge 2 commits into
tmux:masterfrom
Mr-Neutr0n:fix/menu-border-lines-none

Conversation

Copy link
Copy Markdown

Summary

  • size and position menus without frame rows or columns when menu-border-lines is none
  • keep hidden titles from reserving width in borderless menus
  • use the same geometry for rendering, cursor placement, resize, and mouse hit testing

Addresses #4897.

Testing

  • make -j4
  • focused screen-redraw-menus.sh no-border regression
  • regress/menu-mouse.sh
  • full regression run: related tests pass; three unrelated existing macOS/timing failures remain in copy-mode-selection-scroll.sh, format-mouse.sh, and the menu-over-split golden

Prepared with OpenAI Codex assistance; I reviewed and tested the changes.

nicm commented Aug 6, 2026

Copy link
Copy Markdown
Member

Looks good but try this:

tmux new
tmux set menu-border-lines none
tmux neww
tmux display-menu -t%0 a b c
tmux selectw -t%0

The menu has lines even though that window is configured with none.

nicm moved this from Not Started to Waiting in Open Issues & PRs Aug 6, 2026

Copy link
Copy Markdown
Author

Thanks, I reproduced the exact sequence. The issue was that display-menu read menu-border-lines from the current window after neww instead of the explicitly targeted window (%0), so it saw the default border setting. I updated it to use the target window options, added a regression case for this sequence, and verified the rebuilt binary renders the borderless menu. Commit 2776e2e is pushed for recheck.

Copy link
Copy Markdown
Author

Rebased and resolved the conflicts.

Mr-Neutr0n force-pushed the fix/menu-border-lines-none branch from 2776e2e to cfaa657 Compare August 18, 2026 06:02

nicm commented Aug 18, 2026

Copy link
Copy Markdown
Member

I think this looks good now, thanks. This will be for after 3.8 and I will look at it again after that is released.

nicm moved this from Waiting to For Review in Open Issues & PRs Aug 18, 2026
nicm mentioned this pull request Aug 18, 2026
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: For Review

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL