fix: avoid bash-only [[ in current_session_name - #1003
Merged
akofink merged 2 commits intoJul 10, 2026
Merged
akofink merged 2 commits into
akofink merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Metadata Fixes tmuxinator#978 Problem `stop_all` shells out through `Util#current_session_name`, which uses bash-only `[[ ... ]]` inside Ruby backticks. On systems where `/bin/sh` is dash (Debian, Ubuntu, Linux Mint), each stop prints `sh: 1: [[: not found`. Solution Check `ENV.key?("TMUX")` in Ruby before running `tmux display-message`, add unit coverage for both branches, and document the fix in the unreleased changelog.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes tmuxinator stop_all emitting sh: 1: [[: not found on systems where /bin/sh is dash, by removing a bash-only [[ ... ]] conditional from Util#current_session_name and handling the “not in tmux” case in Ruby.
Changes:
- Return early from Util#current_session_name when TMUX is not present in the environment (no shell conditional needed).
- Keep the tmux display-message -p "#S" call only for the in-tmux case.
- Add unit tests covering #current_session_name with and without TMUX set, plus a CHANGELOG entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/tmuxinator/util.rb | Replaces bash-only conditional with a Ruby ENV.key?("TMUX") guard before shelling out to tmux. |
| spec/lib/tmuxinator/util_spec.rb | Adds specs for current_session_name behavior when TMUX is present/absent. |
| CHANGELOG.md | Documents the POSIX /bin/sh compatibility fix for stop_all. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
spec/lib/tmuxinator/util_spec.rb
Outdated
Comment thread
spec/lib/tmuxinator/util_spec.rb
Outdated
Metadata Follow-up to tmuxinator#1003 / tmuxinator#978 Problem ENV restoration used truthiness of the original value, so an empty-string TMUX would not be restored correctly across examples. Solution Track whether TMUX was originally present with ENV.key? and restore or delete accordingly via a small with_env helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Fixes #978
Problem / Motivation
tmuxinator stop_all prints sh: 1: [[: not found for each stopped session when /bin/sh is dash (Debian, Ubuntu, Linux Mint).
Util#current_session_name shells out with bash-only [[ ... ]], and Ruby backticks run under /bin/sh.
Solution
Resolve the current session name in Ruby via ENV.key?("TMUX") before calling tmux display-message, so no shell conditional is required.
Testing
Added unit coverage for #current_session_name with and without TMUX set.
Reproduced the original dash error with: