feat: set is_human_readable to false - #44
Open
absporl wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This allows implementations of Serialize to change behavior depending on the encoding method used (e.g. encode as base64 for human readable encodings such as JSON, and encode as binary strings for bencode).
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an implementation of is_human_readable for the bencode Serializer, ensuring it always reports non–human-readable output.
- Added fn is_human_readable(&self) -> bool { false } to ser::Serializer impl for &mut Serializer
src/ser.rs:216
- Consider adding a doc comment for is_human_readable to explain that this serializer always returns false to enforce binary encodings (e.g., for bencode).
fn is_human_readable(&self) -> bool {
src/ser.rs:216
- Add a unit test to verify that is_human_readable() returns false and that serialization branches correctly for non–human-readable formats.
fn is_human_readable(&self) -> bool {
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows implementations of Serialize to change behavior depending on the encoding method used (e.g. encode as base64 for human readable encodings such as JSON, and encode as binary strings for bencode).