Typed **kwargs on field constructors - #2218
Open
vlakius wants to merge 8 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Merging this PR will not alter performance✅ 24 untouched benchmarks Comparing vlakius:develop (3a8b565) with develop (bc4f971) |
Sorry, something went wrong.
waketzheng
reviewed
Jun 17, 2026
Comment thread
tortoise/fields/data.py
Outdated
waketzheng
reviewed
Jun 18, 2026
Comment thread
tortoise/fields/data.py
Outdated
waketzheng
approved these changes
Jun 23, 2026
Copy link
Copy Markdown
Contributor
|
Looks OK for me. @abondar what do you think? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
When will it be merged? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added PEP 692 Unpack[TypedDict] typing to field constructors. **kwargs: Any no longer hides common field args from IDEs/type-checkers.
Motivation and Context
See issue: #2168
How Has This Been Tested?
Checked with MyPy and PyRight and my IDE.
tried to add a typo (es: defualt) and it gets flagged as error
Checklist: