FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Catch to v2.3.0. by jpetso · Pull Request #55 · tplgy/cppcodec · GitHub

/ cppcodec Public

Update Catch to v2.3.0. - #55

Merged
jpetso merged 1 commit into
tplgy:masterfrom
jpetso:master
Aug 20, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Update Catch to v2.3.0.#55
jpetso merged 1 commit into
tplgy:masterfrom
jpetso:master

Conversation

jpetso commented Aug 8, 2018

Copy link
Copy Markdown
Collaborator

This changes the include path from <catch.hpp> to <catch2/catch.hpp>,
and gets rid of all remaining warnings on VS2017.
(VS2015 still emits a bunch of questionable warnings.)

Update Catch to v2.3.0.
b9e3bba 
This changes the include path from <catch.hpp> to <catch2/catch.hpp>,
and gets rid of all remaining warnings on VS2017.
(VS2015 still emits a bunch of questionable warnings.)

jpetso commented Aug 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@SoapGentoo, would you mind checking whether this also works with a system Catch2? Note that the pkg-config file was renamed from catch.pc.in to catch2.pc.in, so I think this means I have to adjust the string in my CMakeLists.txt as well.

If this one works out then I intend to tag v0.2 shortly after.

SoapGentoo commented Aug 10, 2018

Copy link
Copy Markdown
Contributor

@jpetso I'll check it on the weekend, ok?

jpetso commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator Author

Sure, that would be great! I'll be on active vacation for a week and a bit, so I may not be very responsive myself. Much appreciated :)

jpetso mentioned this pull request Aug 12, 2018
Closed

SoapGentoo commented Aug 18, 2018

Copy link
Copy Markdown
Contributor

@jpetso yip, everything fine, this fixes the Catch2 2.3.0 changes. Please merge and cut a new release for us? Thanks!

jpetso merged commit 302dc28 into tplgy:master Aug 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL