FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[CONNECT-2858] Bump protobuf library and grpc version by yziubrytska-wise · Pull Request #17 · transferwise/envoy-api-java · GitHub

/ envoy-api-java Public

[CONNECT-2858] Bump protobuf library and grpc version - #17

Merged
yziubrytska-wise merged 2 commits into
mainfrom
CONNECT-2858
Apr 28, 2026
ConversationCommits (2)ChecksFiles changed
Merged

[CONNECT-2858] Bump protobuf library and grpc version#17
yziubrytska-wise merged 2 commits into
mainfrom
CONNECT-2858

Conversation

yziubrytska-wise commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Context

Protobuf dependency is outdated and it cases a bunch of warnings in the logs.

Checklist

Copilot AI review requested due to automatic review settings April 28, 2026 09:51
yziubrytska-wise requested a review from a team as a code owner April 28, 2026 09:51

platon-github-app-production Bot commented Apr 28, 2026

Copy link
Copy Markdown

Comment /request-review to automatically request reviews from the following teams:

You can also request review from a specific team by commenting /request-review team-name, or you can add a description with --notes "<message>"

💡 If you see something that doesn't look right, check the configuration guide.

Copilot AI reviewed Apr 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mkennedy-wise reviewed Apr 28, 2026
View reviewed changes
Comment thread build.gradle Outdated

def grpcVersion = '1.54.1'
def protobufVersion = '3.21.12'
def grpcVersion = '1.62.2'

mkennedy-wise Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why this version? Not sure it matters that much just curious

yziubrytska-wise Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

honestly because it was the first one compatible with a new protobuf version
but I figured that we could update grpc to 1.79 (which is n-1) and still be compatible, so I updated both protobuf to use the latest 1.3.x patch and grpc.

yziubrytska-wise merged commit 0a2faa7 into main Apr 28, 2026
7 checks passed
yziubrytska-wise deleted the CONNECT-2858 branch April 28, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
mkennedy-wise mkennedy-wise approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL