CONNECT-2858: Fix javadoc encoding in envoy-api-java - #19
Merged
yziubrytska-wise merged 15 commits intoMay 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Comment /request-review to automatically request reviews from the following teams:
You can also request review from a specific team by commenting /request-review team-name, or you can add a description with --notes "<message>" 💡 If you see something that doesn't look right, check the configuration guide. |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
niting3c
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Publish to Maven Central job fails currently complaining about javadoc 'unmappable character (...) for encoding US-ASCII'
https://github.com/transferwise/oss-publish/actions/runs/25173915616/job/74234253751
possible fix could be fix javadoc encoding to use utf-8 instead
Checklist