Add zizmor and harden GitHub Actions workflows - #49
Merged
jeromekelleher merged 2 commits intoJun 30, 2026
Merged
jeromekelleher merged 2 commits into
jeromekelleher merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Jun 26, 2026
jeromekelleher
commented
Jun 30, 2026
Comment thread
.github/actions/build-docs/action.yml
| shell: bash | ||
| run: sudo apt-get update && sudo apt-get install -y ${{ inputs.additional-apt-packages }} | ||
| env: | ||
| ADDITIONAL_APT_PACKAGES: ${{ inputs.additional-apt-packages }} |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Note for reference - this defines the input as a environment variable, so the shell never interpolates the attacker-controlled input.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zizmor is a static analysis method for GitHub actions which mitigates against supply chain attacks (which are a real and scary thing). I think it would be good to apply this across the tskit-dev ecosystem so that we don't get packages hijacked (however unlikely that is).