FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace pre-build-command with declarative install-playwright input by jeromekelleher · Pull Request #51 · tskit-dev/.github · GitHub

/ .github Public

Replace pre-build-command with declarative install-playwright input #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeromekelleher merged 1 commit into from
Jun 30, 2026
Conversation 0 Commits 1 Checks 1 Files changed
Merged

Replace pre-build-command with declarative install-playwright input #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .yml  (2) All 1 file type selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
18 changes: 9 additions & 9 deletions .github/actions/build-docs/action.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ inputs:
required: false
default: ''

pre-build-command:
description: 'Command to run after installing deps but before the docs build'
required: false
default: ''

install-slim:
description: 'Whether to install SLiM'
required: false
default: 'false'

install-playwright:
description: 'Install Playwright (chromium) for docs that render browser screenshots'
required: false
default: 'false'

runs:
using: composite
steps:
Expand Down Expand Up @@ -89,12 +89,12 @@ runs:
echo "PKG_VERSION=$PKG_VERSION"
sed -i s/__PKG_VERSION__/${PKG_VERSION}/g docs/_config.yml

- name: Pre-build
if: inputs.pre-build-command != ''
- name: Install Playwright
if: ${{ inputs.install-playwright == 'true' }}
shell: bash
env:
PRE_BUILD_COMMAND: ${{ inputs.pre-build-command }}
run: ${PRE_BUILD_COMMAND}
PYPROJECT_DIRECTORY: ${{ inputs.pyproject-directory }}
run: uv run --no-default-groups --project=${PYPROJECT_DIRECTORY} --locked --group=docs playwright install --with-deps chromium

- name: Build documentation
shell: bash
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/docs.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ on:
type: string
default: ''

pre-build-command:
description: 'Command to run after installing deps but before the docs build'
required: false
type: string
default: ''

install-slim:
description: 'Whether to install SLiM'
required: false
type: boolean
default: false

install-playwright:
description: 'Install Playwright (chromium) for docs that render browser screenshots'
required: false
type: boolean
default: false

permissions:
contents: read

Expand All @@ -57,8 +57,8 @@ jobs:
with:
pyproject-directory: ${{ inputs.pyproject-directory }}
additional-apt-packages: ${{ inputs.additional-apt-packages }}
pre-build-command: ${{ inputs.pre-build-command }}
install-slim: ${{ inputs.install-slim }}
install-playwright: ${{ inputs.install-playwright }}

- name: Trigger tskit-site rebuild
if: github.ref == 'refs/heads/main'
Expand Down
Back | FazBrowse Home | New Git URL