FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrade to more SDK-style and latest NuGetizer by kzu · Pull Request #15 · tui-cs/NStack · GitHub

/ NStack Public

Upgrade to more SDK-style and latest NuGetizer - #15

Open
kzu wants to merge 1 commit into
tui-cs:mainfrom
kzu:master
Open

Upgrade to more SDK-style and latest NuGetizer#15
kzu wants to merge 1 commit into
tui-cs:mainfrom
kzu:master

Conversation

kzu commented Jun 3, 2017

Copy link
Copy Markdown

Changes include:

  • Adding the empty dependency groups via the built-in supported mechanism
    in NuGetizer (<PackageFile Kind=Dependency Id=_._)
  • Replacing usage of packages.config for PackageReference in both projects
  • Adding NuGet restore workaround for VS2017 Version 15.3.0 Preview 2.0 [26530.1.d15rel]
    where it's broken right now (see Building a new enlistment fails NuGet/Home#5300)

Changes include:
- Adding the empty dependency groups via the built-in supported mechanism
  in NuGetizer (`<PackageFile Kind=Dependency Id=_._`)
- Replacing usage of packages.config for PackageReference in both projects
- Adding NuGet restore workaround for VS2017 Version 15.3.0 Preview 2.0 [26530.1.d15rel]
  where it's broken right now (see NuGet/Home#5300)

kzu commented Jun 3, 2017

Copy link
Copy Markdown
Author

FWIW, I tried the resulting nuget package on iOS and Android apps and no prompts were raised.

Copy link
Copy Markdown
Collaborator

Hello! Just wanted to confirm: this works with the released products right now? I would not want to rely on the upcoming preview for it.

kzu commented Jun 3, 2017

Copy link
Copy Markdown
Author

As almost always, it depends ;).

Users can use any VS that supports the NETStandard you're producing, just like the previous hardcoded nuspec had.

building the nuget package requires VS 15.3 to "just work" (i.e. msbuild /t:restore && msbuild /t:build;pack). But VS 15.2 will work if you pass a dummy value via a property or envvar, named NuGetBuildTasksPackTarget, as noted in the friendly error message.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL