FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: private key with passphrase by cognitus · Pull Request #166 · tweakphp/tweakphp · GitHub

Repository navigation

feat: private key with passphrase - #166

Merged
saeedvaziry merged 6 commits into
tweakphp:mainfrom
cognitus:main
Sep 7, 2025
Merged

saeedvaziry merged 6 commits into
tweakphp:mainfrom
cognitus:main

Conversation

Copy link
Copy Markdown
Contributor

Add the possibility to connect by ssh to host with private key with passphrase

fixes #146

cognitus marked this pull request as draft September 3, 2025 01:40
Comment thread src/renderer/views/SSHConnectView.vue Outdated

Copy link
Copy Markdown
Contributor

Can't wait for this to get merge!

cognitus and others added 3 commits September 3, 2025 14:32
cognitus marked this pull request as ready for review September 6, 2025 21:33
saeedvaziry requested a review from Copilot September 7, 2025 19:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR adds support for SSH private key authentication with passphrase protection, addressing the need to connect to hosts that use encrypted private keys.

  • Added passphrase field to the SSH connection configuration interface
  • Enhanced the SSH connection form to include a passphrase input field for key-based authentication
  • Updated SSH connection logic to handle passphrase-protected private keys

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/types/ssh.type.ts Added passphrase field to ConnectionConfig interface
src/renderer/views/SSHConnectView.vue Added passphrase input field in the SSH connection form
src/main/utils/ssh.ts Updated SSH configuration to support passphrase and authentication handlers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/main/utils/ssh.ts
Comment on lines +18 to +19
passphrase: '',
authHandler: undefined,

Copilot AI Sep 7, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The authHandler property is being added to the config object but it's not defined in the type definition. This could cause TypeScript compilation errors or runtime issues if the SSH client expects a specific type for this property.

Copilot uses AI. Check for mistakes.
Comment thread src/main/utils/ssh.ts
saeedvaziry merged commit b3f1a51 into tweakphp:main Sep 7, 2025
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH not working for private keys with password

4 participants


Back | FazBrowse Home | New Git URL