FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make ScalaTest retrying effect generic by bcarter97 · Pull Request #472 · typelevel/cats-effect-testing · GitHub

Make ScalaTest retrying effect generic - #472

Open
bcarter97 wants to merge 2 commits into
typelevel:series/1.xfrom
bcarter97:471-retrying-generic
Open

Make ScalaTest retrying effect generic#472
bcarter97 wants to merge 2 commits into
typelevel:series/1.xfrom
bcarter97:471-retrying-generic

Conversation

Copy link
Copy Markdown

bcarter97 commented Jul 1, 2023
edited
Loading

Copy link
Copy Markdown
Author

Failing binary compatibility:

method ioRetrying()org.scalatest.enablers.Retrying in interface cats.effect.testing.scalatest.AsyncIOSpec does not have a correspondent in current version

So it's the naming - not sure whether to rename it ioRetrying (it's not IO anymore) for binary compatibility or add ioRetrying implemented with fRetrying, which might cause ambiguous implicit resolution.

After some testing I think having an ioRetrying in terms of fRetrying is fine:

def foo[F[_]: Async, T](t: T): F[T] = Async[F].pure(t)

// resolves ioRetrying implicit
def eventuallyIO: IO[String] = {
  eventually {
    foo[IO, String]("hello")
  }
}

// resolves fRetrying implicit
def eventuallyF[F[_]: Async]: F[String] = {
  eventually {
    foo[F, String]("hello")
  }
}

Copy link
Copy Markdown
Author

@sh0hei I think you approved the last build, is it possible to approve again?

Copy link
Copy Markdown
Author

@sh0hei any chance you can run the build? Otherwise if this is deemed no longer necessary I can close it.

sh0hei self-requested a review December 24, 2023 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement ScalaTest ioRetrying with a generic effect type

1 participant


Back | FazBrowse Home | New Git URL