resolve issues with termios package to fix 'stty speed xxyyzz' - #3770
Merged
rminnich merged 6 commits intoOct 2, 2026
Merged
rminnich merged 6 commits into
rminnich merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## main #3770 +/- ##
==========================================
- Coverage 61.37% 61.32% -0.05%
==========================================
Files 648 648
Lines 45706 45716 +10
==========================================
- Hits 28051 28036 -15
- Misses 17655 17680 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Linux SetTermios now rejects valid termios values returned or produced by existing package APIs.
Review effort: Balanced
Findings: 1
Updates termios handling to support Linux baud-rate changes and reuse platform-specific ioctl wrappers.
Changes:
- Converts Linux baud rates before applying terminal settings.
- Routes SGTTY operations through shared termios helpers.
- Uses platform-specific BSD ioctl constants.
| File | Description |
|---|---|
| pkg/termios/termios_linux.go | Adds Linux baud conversion during setting. |
| pkg/termios/termios_bsd.go | Uses platform-specific ioctl constants. |
| pkg/termios/sgtty.go | Uses shared termios get/set helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
pkg/termios/termios_linux.go
That constant no longer exists in bsd. Signed-off-by: Ronald Minnich <rminnich@gmail.com>
Use the package constants, specifically designed to provide the right values for different kernels. Signed-off-by: Ronald Minnich <rminnich@gmail.com>
Use the old fashioned BAUD flags in Cflags, because the Go unix package still can not handle TIOC?ETS2 and its structs. Signed-off-by: Ronald Minnich <rminnich@gmail.com>
We defined the per-os functions years ago and never used them. This fixes baud rate setting across a number of kernels, particularly Linux. Signed-off-by: Ronald Minnich <rminnich@gmail.com>
rminnich
force-pushed
the
stty2
branch
2 times, most recently
from
d2873f7 to
fac3309
Compare
October 1, 2026 02:56
binjip978
reviewed
Oct 1, 2026
Comment thread
pkg/termios/termios_linux.go
Outdated
Convert returned Linux B* to a rate for Ispeed and Ospeed Add 0 as a possible baud rate. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
binjip978
approved these changes
Oct 2, 2026
rminnich
enabled auto-merge (rebase)
October 2, 2026 04:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baud rate setting never worked on Linux, fix that.
Fix improper code in this package (all of it my fault ...)