FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cmds/core/sshd: add -net flag with vsock and unix listener support by brho · Pull Request #3772 · u-root/u-root · GitHub

/ u-root Public

cmds/core/sshd: add -net flag with vsock and unix listener support - #3772

Open
brho wants to merge 2 commits into
u-root:mainfrom
brho:sshd
ConversationCommits (2)ChecksFiles changed
Open

cmds/core/sshd: add -net flag with vsock and unix listener support#3772
brho wants to merge 2 commits into
u-root:mainfrom
brho:sshd

Conversation

brho commented Oct 1, 2026

Copy link
Copy Markdown

Allow sshd to listen on network types other than TCP (such as vsock and unix domain sockets) via the -net flag, defaulting to tcp.

Assisted-by: LLM

brho requested a review from rminnich October 1, 2026 20:55

codecov Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.41%. Comparing base (8c86aab) to head (b9d8236).

❗ There is a different number of reports uploaded between BASE (8c86aab) and HEAD (b9d8236). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8c86aab) HEAD (b9d8236)
integration/gotests/...-amd64 1 0
pkg/...-amd64 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3772      +/-   ##
==========================================
- Coverage   57.44%   52.41%   -5.03%     
==========================================
  Files         638      281     -357     
  Lines       45524    18768   -26756     
==========================================
- Hits        26151     9838   -16313     
+ Misses      19373     8930   -10443
Flag Coverage Δ
cmds/...-amd64 52.41% <100.00%> (+0.02%) ⬆️
integration/gotests/...-amd64 ?
pkg/...-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 64.04% <100.00%> (+2.29%) ⬆️
cmds/exp 33.08% <ø> (-0.84%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rminnich previously approved these changes Oct 1, 2026
View reviewed changes

rminnich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

do we want this for cpud too? and cpu? or do we have it?

rminnich requested a balanced review from Copilot October 1, 2026 23:40
rminnich added the Awaiting author Waiting for new changes or feedback for author. label Oct 1, 2026
Copilot AI reviewed Oct 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot review overview

🟡 Changes recommended

VSOCK ports are incorrectly restricted to 16 bits, and the new listener paths lack behavioral tests.

Review effort: Balanced
Findings: 1 · 1

Open (2) What changed in this PR

Adds configurable TCP, VSOCK, and Unix socket listeners to sshd.

Changes:

  • Adds the -net listener flag.
  • Introduces network-specific listener creation.
  • Tests the default network value.
File Description
cmds/​core/​sshd/​sshd.go Implements configurable listeners.
cmds/​core/​sshd/​sshd_test.go Checks the default network.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cmds/core/sshd/sshd.go Outdated
Comment thread cmds/core/sshd/sshd_test.go

brho commented Oct 2, 2026

Copy link
Copy Markdown
Author

do we want this for cpud too? and cpu? or do we have it?

already have it: https://github.com/u-root/cpu/blob/790d2c9cd791787904808038e3f32b2e7d72d47e/cmds/cpud/serve.go#L116-L121

oh, and that cpud code also has the ParseInt 16 vs 32 bug that Copilot pointed out. (gemini probably got it from cpud).

brho requested a review from rminnich October 2, 2026 10:33
cmds/core/sshd: add -net flag with vsock and unix listener support
c4a622f 
Allow sshd to listen on network types other than TCP (such as vsock and unix
domain sockets) via the -net flag, defaulting to tcp.

Assisted-by: LLM
Signed-off-by: Barret Rhoden <brho@google.com>
brho added Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Oct 2, 2026

rminnich commented Oct 2, 2026

Copy link
Copy Markdown
Member

can you submit a PR to fix cpud?

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
rminnich Awaiting requested review from rminnich

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL