Attempt to fix circleci test (from Gemini) - #3773
Open
rminnich wants to merge 1 commit into
Open
rminnich wants to merge 1 commit into
rminnich wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I don't recall how to make it try this test out. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3773 +/- ##
==========================================
- Coverage 61.46% 61.31% -0.15%
==========================================
Files 648 648
Lines 45716 45716
==========================================
- Hits 28099 28032 -67
- Misses 17617 17684 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
binjip978
reviewed
Oct 3, 2026
Comment thread
.circleci/config.yml
binjip978
previously approved these changes
Oct 3, 2026
binjip978
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
let's try it, we can always revert
Sorry, something went wrong.
Signed-off-by: Ronald Minnich <rminnich@gmail.com>
binjip978
approved these changes
Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's hard to see how the old rule worked, but I think circleci changed somehow.